From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21793A00C5; Thu, 4 Jun 2020 15:12:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59ED71D5D7; Thu, 4 Jun 2020 15:12:38 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6D2F91C1B7 for ; Thu, 4 Jun 2020 15:12:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AA00E5C01C6; Thu, 4 Jun 2020 09:12:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 04 Jun 2020 09:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= TIzfMjTVVEy82zRUpqIfPc+oD02LPXzXFyjVngKUE58=; b=wqQWNIJn9E7+lheg 2ytk8fjsUzH5EFAR44NYEmI5MtQAFa0MOnTQo0DXde51MdSOuA0dXc5gw/Tkkg2t cz7qgVKfaTOuPbWKdGCZhhNILgfh8tbyt5la2hNj5C351WmUBXywlXLr8dSsvsDo 3y3rTnGSqHV+Y2wlQ2q63/OEvxUQ57Y/zBmjN+JHBw+0kiYht0i3lSOvFBWcbn1o c7oCd8qkJcR3MNsnwf2uin5GIGYP1fAKkkI3Sp2s90kK2AnFswnxnYmic9vvEZB1 M/oBzqI9DBUEnnViAdDuK0e3lC+Ym+i9CFnvINZ+bEqnnKsuHLa9DfiIV6taxZMM syl2tQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TIzfMjTVVEy82zRUpqIfPc+oD02LPXzXFyjVngKUE 58=; b=sWmShwdGK7o9yU38PwiRl0xFknJY+NWs1kkVRI+EPkLHFfbZFvCz42IIl 8JWwnVRhW0QGYVkilPW4OAwUd+uSLc4kZ/EvwblkASVcC2y7XPNUXNtE5vu0rSsL ruwbNwAeGiv2dDsBJf4pqTQImINSrjTtCfeJIe6Abaa8+Qfpxutk+safN6bQhxMt r0bdE5N0znTcoAdm1cUmsEayxQlPQGNSYAP5TSwx52bP18ex9Z2sm5JN+dH96CA8 nUoTG59gM3VKgmfwCiCdX9DFswepqAkw0KMZnCurT2M0tkw2Y7qoLxY97mkuTlFG rByUNDwYTyAspjKaozXcPNfGjtGVQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeguddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffegudekiedvleeuleejkeeuvdeludegheegfedukedugfejiedt tddvffdvvdeunecuffhomhgrihhnpehinhhtvghlrdgtohhmnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5864B3060FE7; Thu, 4 Jun 2020 09:12:35 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: Ori Kam , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "Doherty, Declan" Date: Thu, 04 Jun 2020 15:12:33 +0200 Message-ID: <2597084.FJZeo1sxHm@thomas> In-Reply-To: References: <1591194009-4086-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/8] add flow action map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" (reordered replies to avoid top-post) 04/06/2020 13:21, Iremonger, Bernard: > From: Ori Kam > > From: Bernard Iremonger > > > > > > Add map action to rte_flow API to map a Packet Classification type > > > (pctype) to a flowtype for the i40e PMD. > > > > > > This feature requires changes to be made to the rte_flow code in > > > librte_ethdev, testpmd and the i40e PMD. > > > > > > Bernard Iremonger (8): > > > librte_ethdev: add new flow types and action > > > librte_ethdev: add map filter type > > > librte_ethdev: add map action > > > app/testpmd: parse map actions > > > net/i40e: add map filter > > > net/i40e: add map functions > > > net/i40e: parse map pattern and action > > > doc: release note > > > > Can you please explain more what is the pctype, the flow type, What is the > > general idea beyond this patch set? > > How will the application uses it? > > is it only for i40? > > This patchset is intended to add support in the rte_flow API for the Dynamic Device Personalization (DDP) feature on the Intel i40e PMD by adding a map action. > > https://software.intel.com/content/www/us/en/develop/articles/dynamic-device-personalization-for-intel-ethernet-700-series.html > > pctype means Packet Classification type. > flowtype is the index into the pctype table on the i40e. > > The map action is intended to insert the specified pctype into the pctype table at index specified by the flowtype. > > At present the DDP feature uses the following commands in testpmd: > /* map pctype 15 to flowtype 27 */ > # testpmd> port config 0 pctype mapping update 15 27 > # testpmd> show port 0 pctype mapping > pctype: 15 -> flowtype: 27 > > > In future the application will create the following rule: > # testpmd> flow create 0 ingress pattern end actions map pctype 15 flowtype 27 / end > # testpmd> show port 0 pctype mapping > pctype: 15 -> flowtype: 27 This usage looks really Intel-specific. If the application has to consider the Intel-specific ids, then it is not generic. Having some HW specific API makes no sense in the generic ethdev API. Sorry I must say NACK. Could this code be in drivers/net/i40e/rte_pmd_i40e.h ?