From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f177.google.com (mail-wj0-f177.google.com [209.85.210.177]) by dpdk.org (Postfix) with ESMTP id 3D580558A for ; Wed, 30 Nov 2016 15:32:52 +0100 (CET) Received: by mail-wj0-f177.google.com with SMTP id mp19so175814471wjc.1 for ; Wed, 30 Nov 2016 06:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=bp88UxXfu+oQaMAJrtD3fJSiYAuuxe5lr1HZy0iap64=; b=bLLspTnpZzAVPnWk/6fNAfEWsqNECNuEI3iD1Jj2EnsIuYLWhXjb1hKUHbVq8lCOpg PkYkFL34iWYez8o6W6ylpFyf11h1h8fybi0sZjH9tb/0yw4sjonCS6o3o29NSCt1JIIP 0vJJ8q66o3l5GanFFXxaRN13bQaZJGiykf8rx2a76kb3NuXgvcmivBOZoE3BF71HGBpx mX579bvqKeNPLGKBEmD0ooetn4T5ClaxZ8Iee/mkuhUXk1heMTDeiaSjtT9TpbQvvtoL 5E7RRhY6rxNyY7D3tEZIjbcP9uweZ1nSRKpdbBY7APWzLn74aE97i1cqC5KsouvdtK4M 9hXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=bp88UxXfu+oQaMAJrtD3fJSiYAuuxe5lr1HZy0iap64=; b=NUKW+tvOvtRqQ7op3Zm8LfTscSd9rd9Rzjz8EAFcHH4q1QKsL+S3kx0OQ6hXc/ZeYv EgPwzVBaBbzXhBQ2Z5NmHqok3cx9LiGZ+jr2vKKvSI0nVIHX3YZof4xdueBJ14dqQFy1 Zu5dTCG7MgnGgLt5vmHZ68wBl6FcyzkIesnIi4BhNaPOqFIXkSxxT7kszHPxjDsV4cpq GX1xdH/zytuChrSuJ262dKCrc8Bp+NoU+dEgUhaRmcqigv+4kpYlypUhh7QVbuZFaRV0 oWJh5dec4b1VdE/6CAJCVS2/LhRwOXvOqZALseAG/YRvjFVJ8fodMgfHyRzl7SWHxViE L80g== X-Gm-Message-State: AKaTC00R0plYibnF43aR2KAzmrYmCosjKlP1lsvfmvbdrLhsXyEIM3HkkabsK+NS1mubEw9O X-Received: by 10.194.137.15 with SMTP id qe15mr31679950wjb.16.1480516371954; Wed, 30 Nov 2016 06:32:51 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r138sm8305027wme.9.2016.11.30.06.32.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 06:32:51 -0800 (PST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org Date: Wed, 30 Nov 2016 15:32:50 +0100 Message-ID: <25974685.oBJZqL8qqr@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161128162110.23127b42@platinum> References: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> <20161128162110.23127b42@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] scripts: fix checkpatch from standard input X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 14:32:52 -0000 2016-11-28 16:21, Olivier Matz: > On Mon, 21 Nov 2016 23:42:41 +0100, Thomas Monjalon > wrote: > > When checking a valid patch from standard input, > > the footer lines of the report are not filtered out. > > > > The function check is called outside of any loop, > > so the statement continue has no effect and the footer is printed. > > > > Fixes: 8005feef421d ("scripts: add standard input to checkpatch") > > > > Signed-off-by: Thomas Monjalon > > The 'continue' statement is not always without effect. On my machine > (but it looks it's not the same everywhere): > - with dash, the 'continue' acts like a return in that case > - with bash, it displays an error: > "continue: only meaningful in a `for', `while', or `until' loop" > - with bash --posix, the 'continue' is ignored... > > In my case, checkpatches.sh was displaying "0/1 valid" although there > was no error. This patch solves the issue, thanks. > > > Acked-by: Olivier Matz I've amended with your explanations and applied, thanks