From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED349A00C2; Thu, 6 Oct 2022 17:15:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E269542CC6; Thu, 6 Oct 2022 17:15:01 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CEDD742C9D for ; Thu, 6 Oct 2022 17:15:00 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 44A205C0183; Thu, 6 Oct 2022 11:15:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 06 Oct 2022 11:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1665069300; x= 1665155700; bh=to765RBIIvEsSRXW9Sz/zybleTl7V4tSO6rSYlrHJas=; b=U 8PLsgAAFGS4J/ylyibFbgtc92VBhAcuUnT7hn40xeDfBNEnrmygEM8LrhiqJtOih guntBVKRYi3YPMfbTC3erOVytrzvOhr63kkSl8bCkQEUfnXuhy1lQLugv2hISFJY SIigolnLiNs56fDDW7AQyAhuEsgQmSX2uN0xBkxb+hr9kr+HKexYyhYUhGYuLIrU isTLDa6QKIsLOJBNxGieQuRkL+qCT677SfRbNvdBueKE+y6UdFMWNTkcjZ74Rbcp zS6WWEzkLg6rrRmpkWDQ6gFSs4gWNpgmzVHdkdgbs6stBpmvKJQIsHBxgDMoblpd 9pwmfVM8PTqaiSgSIx15g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1665069300; x= 1665155700; bh=to765RBIIvEsSRXW9Sz/zybleTl7V4tSO6rSYlrHJas=; b=g mrY708tJqx6wac8P7ETyfvFFDAY8QqD9WsnlCZTSNjbMOhCTJabK+XWE02+mr0mC 7YT5HdNRAUm5H58ettWtFvJtzqYLZm+bqiYUWBrMRNcW7EC68i1sENLvsukklUKY 8vQMtiqXUDv2/4GPSIW20wnGhQletPjmQie421ut7o3lj1J49etv4MDHvTs/PbiM bpjMpyC3YdnEfooZfNjQr9sEE44KommrcceW8KRyPnzIaYpq1tTpaGr6OQ8HhLP/ LEsXMKky+hsuUCJNEKMf7KnQxKoU4vZzvkUkd+cI4CncUYazGoQnKMuBKHIV3Tnt x+j/5erG5gumNYznMKvSQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeihedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Oct 2022 11:14:57 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: David Marchand , dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API Date: Thu, 06 Oct 2022 17:14:55 +0200 Message-ID: <2599081.BddDVKsqQX@thomas> In-Reply-To: <20221006151020.GA2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <2082798.OBFZWjSADL@thomas> <20221006151020.GA2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/10/2022 17:10, Tyler Retzlaff: > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > 05/10/2022 18:34, Tyler Retzlaff: > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > > > > > i will make this change in the next revision. if anyone does object i > > > > hope they will do so quickly. > > > > > > looking at this more closely i'm going to back away from making the > > > adjustment here. if Thomas and/or Dmitry could comment it would be > > > appreciated. > > > > > > it appears that functions placed in eal_common_xxx files are consumed > > > internally by the eal where rte_xxx files are functions that are exposed > > > through public api. > > > > It is not so clear. > > There is already eal_common_thread.c which implements the same kind of functions, > > so I think you should move your new functions here. > > > > > since these additions are public api it seems they should remain in > > > rte_thread.c > > > > Let's not have 2 .c files for the same purpose in the same directory. > > just as another point there seem to be several other rte_xxx.c files > here can we clarify why they were not subject to the same requirement? > as a follow on does it mean that the code in those files should also be > moved to eal_common_xxx files? That's just history. > please let me know if the justification is not the same i'll move the > functions to the eal_common file as requested. i just want to make sure > it is being done for the consistent/correct reason. Some file names are not correct, we could rename them. I think David is already doing the last minor changes on this series while merging, so no need to do anything on your side.