From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EFEDA0547; Wed, 21 Apr 2021 13:46:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C79F241A8F; Wed, 21 Apr 2021 13:46:53 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D071641A72; Wed, 21 Apr 2021 13:46:50 +0200 (CEST) IronPort-SDR: 1TqKCyNkr2V5i0a0elgUzTRXAGi7gnesX/B1yOJfP+zWWKRD/hwkJTqS9FLr4ypAPDaYtc7Ifi y/Uy3zMdbfSg== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="216323194" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="216323194" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 04:46:49 -0700 IronPort-SDR: kB+Ojj6WRJZNB6Sqr2li7ibkoxGJ++duhgsSw9K2Uc5WSh1iqBjBzu6ivrWsPRNLY3TOG+LyC9 12jIr/XC2whw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="534854930" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2021 04:46:49 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 04:46:48 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 19:46:46 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Wed, 21 Apr 2021 19:46:46 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Zhang, AlvinX" , "Guo, Jia" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/igc: fix Rx packet size error Thread-Index: AQHXNY1d3jlflE8270KdcHYq8Fpqb6q+3Nig Date: Wed, 21 Apr 2021 11:46:46 +0000 Message-ID: <259f1a9d353a4da8a447b92acdc6c20e@intel.com> References: <20210416011407.29236-1-alvinx.zhang@intel.com> <20210420020520.17936-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wang, Haiyue > Sent: Tuesday, April 20, 2021 10:31 AM > To: Zhang, AlvinX ; Guo, Jia > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error >=20 > > -----Original Message----- > > From: Zhang, AlvinX > > Sent: Tuesday, April 20, 2021 10:05 > > To: Wang, Haiyue ; Guo, Jia > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [PATCH v2] net/igc: fix Rx packet size error > > > > When DEV_RX_OFFLOAD_KEEP_CRC is enabled, the PMD will minus 4 bytes > of > > CRC from the size of a packet, but the NIC will strip the CRC because > > the CRC strip bit in DVMOLR register is not cleared. This will cause > > the size of a packet to be 4 bytes less. > > > > This patch updates the CRC strip bit according to whether > > DEV_RX_OFFLOAD_KEEP_CRC is enabled. > > > > Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > > > v2: Refine the codes. > > --- > > drivers/net/igc/igc_txrx.c | 30 ++++++++++++++++-------------- > > 1 file changed, 16 insertions(+), 14 deletions(-) > > >=20 > Acked-by: Haiyue Wang >=20 > > -- > > 1.8.3.1 Applied to dpdk-next-net-intel. Thanks Qi