From: "Min Hu (Connor)" <humin29@huawei.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core
Date: Thu, 29 Apr 2021 17:37:04 +0800 [thread overview]
Message-ID: <259f4b9c-287a-f227-637e-029aef7aa010@huawei.com> (raw)
In-Reply-To: <DM6PR11MB2890816E949391F28E3542AEEF5F9@DM6PR11MB2890.namprd11.prod.outlook.com>
Thanks Bernard .
Hi, Thomas, Ferruh, any other comments?
在 2021/4/29 17:07, Iremonger, Bernard 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Thursday, April 29, 2021 1:51 AM
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>; thomas@monjalon.net
>> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core
>>
>> According to the comments and logging, the author just hope user to use the
>> core and device which are in the same numa node for optimal performance.
>> If not, A warning gives out.
>>
>> For example in flow_classify:
>> ./build/flow_classify -a 0000:7d:00.1 -l 93
>> Here:
>> 0000:7d:00.1 is on numa node 0.
>> core 93 is on numa node 3.
>>
>> The two are not in same numa node, but no warning gives out in old codes.
>>
>> This patch can fix it.
>>
>> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>
> Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
> .
>
next prev parent reply other threads:[~2021-04-29 9:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:40 [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-20 1:08 ` Thomas Monjalon
2021-04-20 2:26 ` Min Hu (Connor)
2021-04-20 9:40 ` Thomas Monjalon
2021-04-27 11:51 ` Iremonger, Bernard
2021-04-27 12:23 ` Min Hu (Connor)
2021-04-27 13:06 ` Iremonger, Bernard
2021-04-28 9:26 ` Iremonger, Bernard
2021-03-27 7:40 ` [dpdk-dev] [PATCH 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-10 9:14 ` [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-04-19 7:44 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-28 13:29 ` Iremonger, Bernard
2021-04-29 0:51 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 0/3] " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-29 9:07 ` Iremonger, Bernard
2021-04-29 9:37 ` Min Hu (Connor) [this message]
2021-04-29 11:44 ` Thomas Monjalon
2021-04-29 12:15 ` Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 3/3] examples/skeleton: " Min Hu (Connor)
2021-05-12 16:52 ` [dpdk-dev] [PATCH v3 0/3] " Ferruh Yigit
2021-05-12 19:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259f4b9c-287a-f227-637e-029aef7aa010@huawei.com \
--to=humin29@huawei.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).