From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 916B3A0547; Thu, 29 Apr 2021 11:37:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1713C41194; Thu, 29 Apr 2021 11:37:11 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 5F68E41125 for ; Thu, 29 Apr 2021 11:37:09 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FW9MY1FJ7zjcJ9; Thu, 29 Apr 2021 17:35:05 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 29 Apr 2021 17:37:04 +0800 To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "thomas@monjalon.net" References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1619657448-57567-1-git-send-email-humin29@huawei.com> <1619657448-57567-2-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <259f4b9c-287a-f227-637e-029aef7aa010@huawei.com> Date: Thu, 29 Apr 2021 17:37:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Bernard . Hi, Thomas, Ferruh, any other comments? ÔÚ 2021/4/29 17:07, Iremonger, Bernard дµÀ: >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Thursday, April 29, 2021 1:51 AM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Iremonger, Bernard >> ; thomas@monjalon.net >> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core >> >> According to the comments and logging, the author just hope user to use the >> core and device which are in the same numa node for optimal performance. >> If not, A warning gives out. >> >> For example in flow_classify: >> ./build/flow_classify -a 0000:7d:00.1 -l 93 >> Here: >> 0000:7d:00.1 is on numa node 0. >> core 93 is on numa node 3. >> >> The two are not in same numa node, but no warning gives out in old codes. >> >> This patch can fix it. >> >> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) > > Tested-by: Bernard Iremonger > Acked-by: Bernard Iremonger > > . >