From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C768DA0521; Tue, 3 Nov 2020 15:45:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2BD7CAF8; Tue, 3 Nov 2020 15:45:08 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id CF90ECAE0 for ; Tue, 3 Nov 2020 15:45:07 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id 10so14378734pfp.5 for ; Tue, 03 Nov 2020 06:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GGveIiI9hSZ4S5/tz7RHA4fbjA6K1LPdNAOxpfA8uGs=; b=BPgK+QuMF72yXss8IqcGhxRAgBrLbFb0p5MxjS0s6gEvvzC8iks4gyqxRqKNqIeKO+ hqIrtcNQO+gFYnhyBOei2h6pz1MvoBE3JaSArH0o/NbPFUHkctes7g4ouF7YlRQol5e6 QdVSbI7qtIGMTMhg7z2UZFCxOEGV3r4DI/TevXf2YtbobyszJAOFMMNrtXW32ACyFPXw Jgj63YyF3ZKsQPa5Bo4ucjWlT21y0+DM9uFtGpa2Qv0J2VuvtYe/M1dVeqNET9G00++q c8XwQ2ro/c9WmGeik5RvlOomE7JVsKf4U4ARwFw3KLsnMJrWOJOijjeM1m0/5Pgidbw1 r3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GGveIiI9hSZ4S5/tz7RHA4fbjA6K1LPdNAOxpfA8uGs=; b=GJ4YVjcYnFd93FA1bl5WcgqeTKAHJE/sgJVQAXj3jlo59OYT2c6xngtgXxgQi029MW g+GX6w6zneSBbet7I45uzeDvP01dHCTxnGtbrkdg1py7m7Au7yNa+7xnydfSuLXaM7j6 Ki8/w8AT3w05QaynMLE32vvlXaBtcfwuNgquZiwkUrlN+PPT+tvM1TkMtdDtau/CyLVC epKMhsOmWNdFfzqcDpggAzVRa6iJ/Jz3DAFJChh7kKT8vH3rGOjrlHVklpjR0ox53Df+ xAuD5PrilV+rYXih1g7Yzpi5k6S4s+snGwB3horE/NB9uYhdbFl2uEeIkCMzul/7JC6b g1YA== X-Gm-Message-State: AOAM532UWfw4hAZq34QRsLk9Icxjp2ExwBgCOPQMdNWo5ttSVDpA1PVH W4Qo9f4+5HC3TSpD5M9l3uClyg== X-Google-Smtp-Source: ABdhPJyOTKKA1r2g5O7lWLsO21jgRfVYYwqCLlw+x1MlXCobanOrIv+wXHAxmsNnkh1SAL4GrEk5Bg== X-Received: by 2002:a62:5e06:0:b029:164:a9ca:b07e with SMTP id s6-20020a625e060000b0290164a9cab07emr25510845pfb.36.1604414706078; Tue, 03 Nov 2020 06:45:06 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:509e:4fc5:4531:4206? ([2600:1700:6b0:fde0:509e:4fc5:4531:4206]) by smtp.gmail.com with ESMTPSA id a10sm3536145pjq.17.2020.11.03.06.45.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 06:45:05 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <4b0ab4ff-4bf8-a4a5-67fe-11ad8d7d45c3@intel.com> Date: Tue, 3 Nov 2020 09:45:03 -0500 Cc: dev@dpdk.org, cardigliano@ntop.org Content-Transfer-Encoding: quoted-printable Message-Id: <25B808DE-D7C4-457D-A5BE-C91248BD3193@pensando.io> References: <20201102183527.69209-1-aboyer@pensando.io> <4b0ab4ff-4bf8-a4a5-67fe-11ad8d7d45c3@intel.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 3, 2020, at 8:11 AM, Ferruh Yigit = wrote: >=20 > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> These patches make some minor changes to the ionic PMD. This is my = first >> patch submission to DPDK, so please let me know if there is anything = amiss. >> Andrew Boyer (8): >> ionic: update documentation and MAINTAINERS >> ionic: connect to the meson build system >> ionic: update ionic_if.h to the latest version >> ionic: check for devcmd/admincmd completion more frequently >> ionic: remove some unused fields >> ionic: convert 'deferred' boolean to a flag bit >> ionic: warn if RTE tries to enable loopback mode >> ionic: nits - whitespace, logging, helper variables >=20 > Hi Andrew, >=20 > Can you please use "net/ionic: " prefix for the patch titles. >=20 > Also please fix warnings of the following scripts: > ./devtools/checkpatches.sh -n8 > ./devtools/check-git-log.sh -n8 >=20 > checkpatch reports following typos, you need codespell to see them, I = am pasting here for any case: >=20 > ### ionic: update ionic_if.h to the latest version >=20 > WARNING:TYPO_SPELLING: 'Maximim' may be misspelled - perhaps = 'Maximum'? > #355: FILE: drivers/net/ionic/ionic_if.h:404:=20 > + * @max_frame_size: Maximim size of frames to be sent >=20 > WARNING:TYPO_SPELLING: 'tranceiver' may be misspelled - perhaps = 'transceiver'? > #1158: FILE: drivers/net/ionic/ionic_if.h:1236: > + * @xcvr: tranceiver status >=20 > WARNING:TYPO_SPELLING: 'autonegotation' may be misspelled - perhaps = 'autonegotiation'? > #1219: FILE: drivers/net/ionic/ionic_if.h:1328: > + * @IONIC_PORT_ATTR_AUTONEG: Port autonegotation attribute Thank you. Your bot responded immediately with the same spelling issues = and Travis caught the 32-bit build issue (%#lx). -Andrew=