[dpdk-dev] fix mbuf->port for eth_af_packet

[dpdk-dev] fix mbuf->port for eth_af_packet

[Krauz, Pavel]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

Hello,
Here goes patch for DPDK 2.2.0.rc3 that fixes reported port number in mbuf when eth_af_packet PMD is used.

b.r.
Pavel Krauz


[-- Attachment #2: dpdk_af_packet.patch.txt --]
[-- Type: text/plain, Size: 698 bytes --]

--- dpdk-2.2.0-rc3/drivers/net/af_packet/rte_eth_af_packet.c.bak	2015-12-09 14:37:47.777957118 +0100
+++ dpdk-2.2.0-rc3/drivers/net/af_packet/rte_eth_af_packet.c	2015-12-09 14:51:10.612877611 +0100
@@ -74,6 +74,7 @@
 	unsigned int framenum;
 
 	struct rte_mempool *mb_pool;
+	uint8_t in_port;
 
 	volatile unsigned long rx_pkts;
 	volatile unsigned long err_pkts;
@@ -160,6 +161,8 @@
 		ppd->tp_status = TP_STATUS_KERNEL;
 		if (++framenum >= framecount)
 			framenum = 0;
+		
+		mbuf->port = pkt_q->in_port;
 
 		/* account for the receive frame */
 		bufs[i] = mbuf;
@@ -365,7 +368,7 @@
 	}
 
 	dev->data->rx_queues[rx_queue_id] = pkt_q;
-
+	pkt_q->in_port = dev->data->port_id;
 	return 0;
 }
 

Re: [dpdk-dev] fix mbuf->port for eth_af_packet

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Krauz, Pavel
> Sent: Wednesday, December 9, 2015 2:10 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] fix mbuf->port for eth_af_packet
> 
> Hello,
> Here goes patch for DPDK 2.2.0.rc3 that fixes reported port number in mbuf
> when eth_af_packet PMD is used.

Hi Pavel,

Thanks for that. Could you resubmit the patch with a signoff line and in a
git diff format. See the draft Contributors Guide:

   http://dpdk.org/dev/patchwork/patch/9019/

Regards,

John.
-- 

Re: [dpdk-dev] fix mbuf->port for eth_af_packet

[Krauz, Pavel]

Hello,
Here goes the patch again in the correct format.
Thanks & b.r.
Pavel

Re: [dpdk-dev] fix mbuf->port for eth_af_packet

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Krauz, Pavel
> Sent: Wednesday, December 9, 2015 2:47 PM
> To: dev@dpdk.org
> Subject: Re: [dpdk-dev] fix mbuf->port for eth_af_packet
> 
> Hello,
> Here goes the patch again in the correct format.
> Thanks & b.r.
> Pavel

Hi Pavel,

There wasn't a patch submitted that I can see. Maybe send a few test emails to yourself first to see if it works.

Also, once it is working you should send the email to the maintainer of af_packet and CC dev@dpdk.org. 

    $ grep -B 1 af_packet MAINTAINERS 
    M: John W. Linville <linville@tuxdriver.com>
    F: drivers/net/af_packet/

You will also need to mark the previous patch(es) as superseded:

    http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=390

John.
-- 

Re: [dpdk-dev] fix mbuf->port for eth_af_packet

[Thomas Monjalon]

2015-12-09 15:03, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Krauz, Pavel
> > Hello,
> > Here goes the patch again in the correct format.
> > Thanks & b.r.
> > Pavel
> 
> Hi Pavel,
> 
> There wasn't a patch submitted that I can see. Maybe send a few test emails to yourself first to see if it works.
> 
> Also, once it is working you should send the email to the maintainer of af_packet and CC dev@dpdk.org. 
> 
>     $ grep -B 1 af_packet MAINTAINERS 
>     M: John W. Linville <linville@tuxdriver.com>
>     F: drivers/net/af_packet/
> 
> You will also need to mark the previous patch(es) as superseded:
> 
>     http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=390

Thanks John for reminding the guidelines.

Pavel, it seems to be your first contribution to DPDK.
If you cannot submit it properly with git, we'll manage it
manually. We just need a description of the issue and a Signed-off.
Thanks