From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Ivan Malov" <ivan.malov@arknetworks.am>,
"Andy Moreton" <andy.moreton@amd.com>
Subject: Re: [PATCH v4] common/sfc: replace out of bounds condition with static_assert
Date: Mon, 12 Feb 2024 12:09:35 +0000 [thread overview]
Message-ID: <25dd0757-c832-49ae-a407-cba125632ff0@amd.com> (raw)
In-Reply-To: <20240212054917.12475-1-stephen@networkplumber.org>
On 2/12/2024 5:48 AM, Stephen Hemminger wrote:
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
>
> The use of null pointer to compute offset is not always a constant
> in older versions of clang. Use standard offsetof() instead.
>
> Fixes: f67e4719147d ("net/sfc/base: fix coding style")> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
>
Looks good to me,
unless there is no objection from driver maintainers I will merge it.
next prev parent reply other threads:[~2024-02-12 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 20:18 [PATCH] " Stephen Hemminger
2024-01-18 23:05 ` Morten Brørup
2024-02-13 7:47 ` Andrew Rybchenko
2024-01-19 22:13 ` [PATCH v2] " Stephen Hemminger
2024-01-20 7:53 ` Morten Brørup
2024-02-07 19:10 ` Ferruh Yigit
2024-02-07 22:34 ` Stephen Hemminger
2024-02-07 22:36 ` Stephen Hemminger
2024-02-07 23:30 ` Ferruh Yigit
2024-02-11 17:41 ` Stephen Hemminger
2024-02-11 22:24 ` [PATCH] " Stephen Hemminger
2024-02-12 5:48 ` [PATCH v4] " Stephen Hemminger
2024-02-12 12:09 ` Ferruh Yigit [this message]
2024-02-13 9:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25dd0757-c832-49ae-a407-cba125632ff0@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=andy.moreton@amd.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@arknetworks.am \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).