DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
Date: Thu, 16 Sep 2021 10:36:37 +0000	[thread overview]
Message-ID: <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com> (raw)

Currently, when VFIO support is not compiled, FreeBSD and Linux have
different return values. Fix Linux implementation to follow FreeBSD one.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    Current minimum support Linux kernel is 4.4, and Meson build file sets the
    RTE_EAL_VFIO config option to `true` simply because we are compiling for Linux.
    So, it looks like VFIO support is pretty much assumed on Linux, so i think we
    can safely drop the fallback dummy implementation from Linux altogether?

 lib/eal/linux/eal_vfio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
index 25add2fa5d..b9e4d3ad3c 100644
--- a/lib/eal/linux/eal_vfio.c
+++ b/lib/eal/linux/eal_vfio.c
@@ -2111,19 +2111,19 @@ rte_vfio_enable(__rte_unused const char *modname)
 int
 rte_vfio_is_enabled(__rte_unused const char *modname)
 {
-	return -1;
+	return 0;
 }
 
 int
 rte_vfio_noiommu_is_enabled(void)
 {
-	return -1;
+	return 0;
 }
 
 int
 rte_vfio_clear_group(__rte_unused int vfio_group_fd)
 {
-	return -1;
+	return 0;
 }
 
 int
-- 
2.25.1


             reply	other threads:[~2021-09-16 10:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 10:36 Anatoly Burakov [this message]
2021-09-16 10:36 ` [dpdk-dev] [PATCH v1 2/2] vfio: add errno on unsupported platforms Anatoly Burakov
2021-09-16 10:39   ` Bruce Richardson
2021-09-22  3:31   ` Xia, Chenbo
2021-09-22  3:30 ` [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent Xia, Chenbo
2021-09-22  9:26   ` Ferruh Yigit
2021-09-22 11:30     ` Xia, Chenbo
2021-10-28  8:21       ` David Marchand
2021-10-28 10:29   ` Burakov, Anatoly
2021-10-28 11:11     ` Xia, Chenbo
2021-10-28 11:32       ` Ferruh Yigit
2021-10-28 13:00         ` Burakov, Anatoly
2021-10-28 14:53         ` Thomas Monjalon
2021-10-28 15:40           ` Burakov, Anatoly
2021-10-28 16:38             ` Stephen Hemminger
2021-10-28 13:49 ` [dpdk-dev] [PATCH v2 1/4] vfio: drop fallback Linux implementation Anatoly Burakov
2021-10-28 13:49   ` [dpdk-dev] [PATCH v2 2/4] vfio: fix wrong return value for FreeBSD Anatoly Burakov
2021-10-28 13:49   ` [dpdk-dev] [PATCH v2 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
2021-10-28 13:49   ` [dpdk-dev] [PATCH v2 4/4] vfio: add errno on unsupported platforms Anatoly Burakov
2021-10-28 14:13     ` Burakov, Anatoly
2021-10-28 14:15   ` [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation Anatoly Burakov
2021-10-28 14:15     ` [dpdk-dev] [PATCH v3 2/4] vfio: fix wrong return value for FreeBSD Anatoly Burakov
2021-11-05  2:50       ` Xia, Chenbo
2021-10-28 14:15     ` [dpdk-dev] [PATCH v3 3/4] vfio: fix documentation to match intended behavior Anatoly Burakov
2021-11-05  2:57       ` [dpdk-dev] [dpdk-stable] " Xia, Chenbo
2021-10-28 14:15     ` [dpdk-dev] [PATCH v3 4/4] vfio: add errno on unsupported platforms Anatoly Burakov
2021-11-08 15:55       ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-11-01  6:27     ` [dpdk-dev] [PATCH v3 1/4] vfio: drop fallback Linux implementation Xia, Chenbo
2021-11-01 13:57       ` Burakov, Anatoly
2021-11-05  2:48         ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).