Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/22/2018 8:47 PM, Thomas Monjalon wrote:
> 22/05/2018 20:35, Ferruh Yigit:
>> vdevs detach on testpmd exit implemented as workaround to fix
>> a virtio-user issue. The issue was virtio-user cleanup is not
>> called and existing socket file not cleaned up which will fail
>> next run.
>>
>> The vdev cleanup causing problems in failsafe PMD.
>>
>> Reduce the cleanup to only virtio-user and add a comment that this
>> workaround should be converted to a proper cleanup, not something
>> specific to virtio-user, and not something specific to vdev and
>> testpmd.
>>
>> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> OK to squash it with above patch.

Squashed into relevant commit in next-net, thanks.

> Thanks for the update.
> 
> Note: this patch is not related to failsafe.
> There was a deadlock introduced in 18.05-rc1 when detaching failsafe,
> but it is fixed by using a recursive lock in vdev.

Thanks for the clarification, I mixed the issues.