From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug
Date: Thu, 21 Jan 2021 10:52:16 +0000 [thread overview]
Message-ID: <25ff2e74-1188-daa5-19ff-731f615238c3@intel.com> (raw)
In-Reply-To: <25223796.ZyEVLiDlFK@thomas>
On 19-Jan-21 11:39 PM, Thomas Monjalon wrote:
> 18/01/2021 16:41, Anatoly Burakov:
>> + /* now that we've validated the request, time for a PSA */
>
> What is PSA?
Public Service Announcement :)
>
>> + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE,
>> + m->free_req.addr, m->free_req.len);
> [...]
>
>> + /* this is checked by the API, but we need to prevent divide by zero */
>> + if (ar->page_sz == 0 || !rte_is_power_of_2(ar->page_sz)) {
>> + RTE_LOG(ERR, EAL, "Attempting to allocate with page size\n");
>
> Is there a missing part in the log message?
>
Seems like it. I'll resubmit.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-01-21 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 12:15 [dpdk-dev] [PATCH] " Anatoly Burakov
2021-01-18 8:26 ` David Marchand
2021-01-18 11:37 ` Burakov, Anatoly
2021-01-18 15:41 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2021-01-19 23:39 ` Thomas Monjalon
2021-01-21 10:52 ` Burakov, Anatoly [this message]
2021-01-22 17:17 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2021-01-27 13:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ff2e74-1188-daa5-19ff-731f615238c3@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).