From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED08A09E4; Thu, 21 Jan 2021 11:52:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 924FC140CFE; Thu, 21 Jan 2021 11:52:22 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A790E140CFC for ; Thu, 21 Jan 2021 11:52:21 +0100 (CET) IronPort-SDR: 8YFZehBGdGUEd4sJgE4fwPvUhIOVIR23L9EdAdTA0W2eoD3y90vXLP47egMzwlxTn5puaNenJI q8yzVHoqqgrg== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="179401973" X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="179401973" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 02:52:20 -0800 IronPort-SDR: YGafyknORzvg046wbVTrHFubxSxTz8U4SW+AkHLV4ZtaMxgkzLBLPJminsJv8wlhqpcXsEeFp+ 73lvmQO/IuFw== X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="385254841" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.224.191]) ([10.213.224.191]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 02:52:19 -0800 To: Thomas Monjalon Cc: dev@dpdk.org References: <9843593ce51003ea5e372a8107a96acdc01e8958.1610712939.git.anatoly.burakov@intel.com> <20ad523bdee024979dfc74cc32c8c02954cd1d4c.1610984505.git.anatoly.burakov@intel.com> <25223796.ZyEVLiDlFK@thomas> From: "Burakov, Anatoly" Message-ID: <25ff2e74-1188-daa5-19ff-731f615238c3@intel.com> Date: Thu, 21 Jan 2021 10:52:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <25223796.ZyEVLiDlFK@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On 19-Jan-21 11:39 PM, Thomas Monjalon wrote: > 18/01/2021 16:41, Anatoly Burakov: >> + /* now that we've validated the request, time for a PSA */ > > What is PSA? Public Service Announcement :) > >> + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, >> + m->free_req.addr, m->free_req.len); > [...] > >> + /* this is checked by the API, but we need to prevent divide by zero */ >> + if (ar->page_sz == 0 || !rte_is_power_of_2(ar->page_sz)) { >> + RTE_LOG(ERR, EAL, "Attempting to allocate with page size\n"); > > Is there a missing part in the log message? > Seems like it. I'll resubmit. -- Thanks, Anatoly