From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EF75F5F11 for ; Wed, 3 Oct 2018 11:18:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 02:18:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="97013411" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 03 Oct 2018 02:17:20 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.45]) by IRSMSX109.ger.corp.intel.com ([169.254.13.3]) with mapi id 14.03.0319.002; Wed, 3 Oct 2018 10:17:19 +0100 From: "Ananyev, Konstantin" To: Jerin Jacob CC: "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Thread-Index: AQHUWoZ16N+S2p7Xg0+YkXutkRYbN6UNN04g///xkwCAABUJMA== Date: Wed, 3 Oct 2018 09:17:18 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580102FE152A@IRSMSX106.ger.corp.intel.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> <20181003085909.GA9894@jerin> In-Reply-To: <20181003085909.GA9894@jerin> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWI4YjM3MzctZDA2OS00OGYxLTliMTQtMmUzYTQ5NDA4ZjY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0VwaVRYckJPMnFHNlgrVjUwbFJcL2ExTzN4Z2dWYUpyY1VrWlJUYmgyOHZoQ2psNDhiQlN0UjM1c0RtV1dkTlUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 09:18:46 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, October 3, 2018 9:59 AM > To: Ananyev, Konstantin > Cc: Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; > Mcnamara, John ; Kovacevic, Marko ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew Ryb= chenko ; Olivier Matz > ; dev@dpdk.org; shahafs@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP c= hecksum definition >=20 > -----Original Message----- > > Date: Wed, 3 Oct 2018 08:53:22 +0000 > > From: "Ananyev, Konstantin" > > To: Jerin Jacob , "Lu, Wenzhuo" > > , "Wu, Jingjing" , > > "Iremonger, Bernard" , "Mcnamara, John" > > , "Kovacevic, Marko" , > > Thomas Monjalon , "Yigit, Ferruh" > > , Andrew Rybchenko = , > > Olivier Matz > > CC: "dev@dpdk.org" , "shahafs@mellanox.com" > > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > checksum definition > > > > > > Hi Jerin, >=20 > Hi Konstantin, >=20 > > > > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > > failure. > > > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum fa= ilure > > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > > > Signed-off-by: Jerin Jacob > > > > Looks ok to me in general. > > Just wonder is there any PMD that supports all these new features? >=20 > octeontx2 PMD has this feature. I am planning to push the PMD for v19.02. > Before that I adding all the common code change to avoid the dependency. Ok, but why then ethdev/mbuf changes has to go into 18.11? Do you plan your new PMD backward compatible with 18.11 LTS? Konstantin