From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 18DEE378B; Tue, 16 Oct 2018 12:40:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 03:40:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,388,1534834800"; d="scan'208";a="95633661" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 16 Oct 2018 03:40:04 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 11:40:03 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.45]) by irsmsx111.ger.corp.intel.com ([169.254.2.200]) with mapi id 14.03.0319.002; Tue, 16 Oct 2018 11:40:03 +0100 From: "Ananyev, Konstantin" To: dev , "dev@dpdk.org" CC: "Yigit, Ferruh" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initialization Thread-Index: AQHUZTk5yAmbKFanm06DsraHZ0Z2p6UhrnEw Date: Tue, 16 Oct 2018 10:40:02 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580102FE779C@IRSMSX106.ger.corp.intel.com> References: <1539684892-19831-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1539684892-19831-1-git-send-email-phil.yang@arm.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQzMDk2YmQtNTU0Mi00NmUwLWJlZDYtYjJlNDIyN2Q3Mjc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSW1jQTBEYk9sREp5eGtNQ085Q1ZkRTEyRFlpd0VYTngrOEJnTWx2RXBiM21zNmJydjc1bzlsTGFmdERTWm5xRiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 10:40:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] > Sent: Tuesday, October 16, 2018 11:15 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; nd@arm.com > Subject: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initializ= ation >=20 > Once the lcore list setting excluded the socket which physic device > attached, it will cause failure. Meanwhile, it will disable Testpmd > cross NUMA scenario. >=20 > Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation") >=20 > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > --- > app/test-pmd/testpmd.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 5dbbf78..4739ddb 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -565,9 +565,21 @@ set_default_fwd_ports_config(void) > portid_t pt_id; > int i =3D 0; >=20 > - RTE_ETH_FOREACH_DEV(pt_id) > + RTE_ETH_FOREACH_DEV(pt_id) { > fwd_ports_ids[i++] =3D pt_id; >=20 > + /* Update sockets info according to the attached device */ > + int socket_id =3D rte_eth_dev_socket_id(pt_id); > + if (socket_id >=3D 0 && new_socket_id(pt_id)) { Should be: ' new_socket_id(socket_id)', I think. Konstantin > + if (num_sockets >=3D RTE_MAX_NUMA_NODES) { > + rte_exit(EXIT_FAILURE, > + "Total sockets greater than %u\n", > + RTE_MAX_NUMA_NODES); > + } > + socket_ids[num_sockets++] =3D socket_id; > + } > + } > + > nb_cfg_ports =3D nb_ports; > nb_fwd_ports =3D nb_ports; > } > -- > 2.7.4