From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 990305699 for ; Wed, 17 Oct 2018 13:02:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 04:02:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="88999177" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 17 Oct 2018 04:02:34 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.45]) by irsmsx105.ger.corp.intel.com ([169.254.7.89]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 12:02:33 +0100 From: "Ananyev, Konstantin" To: "phil.yang@arm.com" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v2] app/testpmd: fix physic port socket initialization Thread-Index: AQHUZboMINOWYNjjJ0GeLaa9DOghhqUjRhPA Date: Wed, 17 Oct 2018 11:02:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580102FE7FA3@IRSMSX106.ger.corp.intel.com> References: <1539684892-19831-1-git-send-email-phil.yang@arm.com> <1539740190-22632-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1539740190-22632-1-git-send-email-phil.yang@arm.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTcyMGRmMTEtYmY4NS00ODIyLTkyNWItYmIwYzcyZjkyYTk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQTZDNitERUJMT3VEd0RSbE16SDM5cFhNbnFDK0RmODEzbEN0MW93MnNGRnZqWjR5K1RKYlwvZVBoUGNOaVZ3NzAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix physic port socket initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 11:02:37 -0000 > -----Original Message----- > From: phil.yang@arm.com [mailto:phil.yang@arm.com] > Sent: Wednesday, October 17, 2018 2:37 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > Subject: [PATCH v2] app/testpmd: fix physic port socket initialization >=20 > Once the lcore list setting excluded the socket which physic device > attached, it will cause failure. Meanwhile, it will disable Testpmd > cross NUMA scenario. >=20 > Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation") >=20 > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > --- > app/test-pmd/testpmd.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 5dbbf78..fd718b0 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -565,9 +565,21 @@ set_default_fwd_ports_config(void) > portid_t pt_id; > int i =3D 0; >=20 > - RTE_ETH_FOREACH_DEV(pt_id) > + RTE_ETH_FOREACH_DEV(pt_id) { > fwd_ports_ids[i++] =3D pt_id; >=20 > + /* Update sockets info according to the attached device */ > + int socket_id =3D rte_eth_dev_socket_id(pt_id); > + if (socket_id >=3D 0 && new_socket_id(socket_id)) { > + if (num_sockets >=3D RTE_MAX_NUMA_NODES) { > + rte_exit(EXIT_FAILURE, > + "Total sockets greater than %u\n", > + RTE_MAX_NUMA_NODES); > + } > + socket_ids[num_sockets++] =3D socket_id; > + } > + } > + > nb_cfg_ports =3D nb_ports; > nb_fwd_ports =3D nb_ports; > } > -- Acked-by: Konstantin Ananyev > 2.7.4