From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 62EB44CBB for ; Tue, 30 Oct 2018 10:46:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 02:46:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="82656441" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga008.fm.intel.com with ESMTP; 30 Oct 2018 02:46:22 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX106.ger.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0415.000; Tue, 30 Oct 2018 09:46:22 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Cody Doucette CC: "dev@dpdk.org" , Gaetan Rivet , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" Thread-Topic: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() Thread-Index: AQHUbqgR2exN42oiTUKXhI6tolcMlKU1I6gAgAAGvACAAmIvsA== Date: Tue, 30 Oct 2018 09:46:21 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725801030656B1@irsmsx105.ger.corp.intel.com> References: <20180727135243.147744-1-doucette@bu.edu> <1549031.gagrcBMtR4@xps> <5318192.uTAyPRLYMi@xps> In-Reply-To: <5318192.uTAyPRLYMi@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmIyNDNiNjUtOGI3Ni00NTk0LWI5MDYtMjQ0MDY0MDZjZmM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib1wva2JlSDRHR3BzRnlkS3duRWFqXC9nQkJcLzhKQTcxaXI2RzJFS3loUWVmelVXRXVyYTBBYUdEU05DWkhXYzZFbiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 09:46:26 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday, October 28, 2018 9:19 PM > To: Cody Doucette > Cc: dev@dpdk.org; Gaetan Rivet ; Ananyev, Konstan= tin ; Olivier Matz > ; Dumitrescu, Cristian ; Michel Machado ; Fu, Qiaobin > > Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6= _fragment_header() >=20 > 28/10/2018 21:54, Cody Doucette: > > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon w= rote: > > > 27/07/2018 15:52, Cody Doucette: > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > > other IPv6 extension headers when finding the fragment header. > > > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > > Fragment extension header will come before any other extension > > > > header, even though it is recommended. > > > > > > > > Signed-off-by: Cody Doucette > > > > Signed-off-by: Qiaobin Fu > > > > Reviewed-by: Michel Machado > > > > --- > > > > v3: > > > > * Removed compilation flag D_XOPEN_SOURCE=3D700 from the > > > > failsafe driver to allow compilation on freebsd. > > > > > > How failsafe is related to ip_frag? > > > > > > > > > > v2: > > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > > > drivers/net/failsafe/Makefile | 1 - > > > > drivers/net/failsafe/meson.build | 1 - > > > > examples/ip_reassembly/main.c | 6 ++-- > > > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++= ++++ > > > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > > > lib/librte_port/rte_port_ras.c | 6 ++-- > > > > > > Changes in failsafe, rte_net and rte_port look like garbage. > > > > > > Anyway, the ip_frag part requires some review. > > > +Cc Konstantin, the maintainer. > > > > Garbage in what sense? I would be happy to amend with a little more > > information. > > > > The changes to failsafe and rte_net were from previous reviews from > > Konstantin: > > > > https://mails.dpdk.org/archives/dev/2018-June/106023.html > > > > https://mails.dpdk.org/archives/dev/2018-July/108701.html >=20 > After a better look, the change in rte_port is fine. >=20 > But the changes in failsafe and rte_net would be better in their own patc= h. > You can have 3 patches in a patchset (with a cover letter to explain the > global idea). > Then, failsafe and rte_net changes must be reviewed by their maintainers. >=20 The patch looks good to me. About failsafe changes - the reason for that was that failsafe driver didn'= t build properly with the proposed changes. Gaetan was ok to remove that extra compiler flag: https://mails.dpdk.org/archives/dev/2018-July/108826.html Konstantin =20