From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone Date: Mon, 12 Nov 2018 22:44:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CE49844@IRSMSX106.ger.corp.intel.com> (raw) In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com> > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Monday, November 12, 2018 8:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Lipiec, Herakliusz <herakliusz.lipiec@intel.com> > Subject: [PATCH] example/ipv4_multicast: fix app hanging when using clone > > This example was dropping packets when using clone (ip 224.0.0.103). > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. > > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> > --- > examples/ipv4_multicast/main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c > index 4073a4907..428ca4694 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone) > hdr->tx_offload = pkt->tx_offload; > hdr->hash = pkt->hash; > > - hdr->ol_flags = pkt->ol_flags; > - > __rte_mbuf_sanity_check(hdr, 1); > return hdr; > } > -- Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > 2.17.1
next prev parent reply other threads:[~2018-11-12 22:44 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-12 20:46 Herakliusz Lipiec 2018-11-12 22:44 ` Ananyev, Konstantin [this message] 2018-11-13 9:25 ` Thomas Monjalon 2018-11-13 9:47 ` Ananyev, Konstantin 2018-11-13 10:21 ` Burakov, Anatoly 2018-11-13 10:28 ` Ananyev, Konstantin 2018-11-13 11:49 ` [dpdk-dev] [PATCH v2] " Herakliusz Lipiec 2018-11-13 11:51 ` Ananyev, Konstantin 2018-11-14 11:33 ` Wang, Dong1 2018-11-18 21:56 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2018-11-14 2:28 ` [dpdk-dev] " Wang, Dong1 2018-11-14 9:02 ` Ananyev, Konstantin 2018-11-14 10:09 ` Wang, Dong1 2018-11-14 10:17 ` Ananyev, Konstantin 2018-11-14 11:06 ` Wang, Dong1 2018-11-14 11:19 ` Ananyev, Konstantin 2018-11-14 11:32 ` Wang, Dong1 2018-11-20 5:40 ` Zhao1, Wei 2018-11-20 9:52 ` Ananyev, Konstantin 2018-11-14 10:21 ` Lipiec, Herakliusz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2601191342CEEE43887BDE71AB977258010CE49844@IRSMSX106.ger.corp.intel.com \ --to=konstantin.ananyev@intel.com \ --cc=dev@dpdk.org \ --cc=herakliusz.lipiec@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git