From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0CFBA34F3; Tue, 13 Nov 2018 12:51:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 03:51:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,499,1534834800"; d="scan'208";a="95928396" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 13 Nov 2018 03:51:41 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 13 Nov 2018 11:51:40 +0000 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.87]) by irsmsx111.ger.corp.intel.com ([169.254.2.195]) with mapi id 14.03.0415.000; Tue, 13 Nov 2018 11:51:40 +0000 From: "Ananyev, Konstantin" To: "Lipiec, Herakliusz" , "dev@dpdk.org" CC: "Wang, Dong1" , "thomas@monjalon.net" , "Burakov, Anatoly" , "stable@dpdk.org" Thread-Topic: [PATCH v2] example/ipv4_multicast: fix app hanging when using clone Thread-Index: AQHUe0b5b7dOcP+BRkqsSp0y8ozILKVNl7zw Date: Tue, 13 Nov 2018 11:51:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> <20181113114929.9269-1-herakliusz.lipiec@intel.com> In-Reply-To: <20181113114929.9269-1-herakliusz.lipiec@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JiODFjODEtNzljOS00NTBjLWIyZGQtNTg2NDBkMzhkMWRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieko0T2lBYzM4UklSQjNSdDhsMWh6UGdFdWV3UTlma0w2T3JrVFJjbXB4KzNCdmNDbVNQRFwvRG1sTTNcL2V4R1ZjIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 11:51:43 -0000 > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Tuesday, November 13, 2018 11:49 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Dong1 ; thomas@monjalon.net; Burakov, > Anatoly ; Lipiec, Herakliusz ; stable@dpdk.org > Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using cl= one >=20 > The ipv4_multicast sample application was dropping packets > when using mbuf clone. When creating an L2 header and copying > metadata from the source packet, the ol_flags were also copied > along with all the other metadata. Because the cloned packet > had IND_ATTACHED_MBUF flag set in its ol_flags, > this caused the packets to never be freed when using rte_pktmbuf_free. > Since copying ol_flags from the cloned packet is > not necessary in the first place, just don't do it. >=20 > Fixes: af75078fece3 ("first public release") > CC: stable@dpdk.org >=20 > Reported-by: Wang Dong > Signed-off-by: Herakliusz Lipiec > --- Acked-by: Konstantin Ananyev