From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EE0DC1D7 for ; Fri, 16 Nov 2018 01:47:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 16:47:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,238,1539673200"; d="scan'208";a="86325538" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga007.fm.intel.com with ESMTP; 15 Nov 2018 16:47:44 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 16 Nov 2018 00:47:43 +0000 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.8]) by irsmsx112.ger.corp.intel.com ([169.254.1.93]) with mapi id 14.03.0415.000; Fri, 16 Nov 2018 00:47:43 +0000 From: "Ananyev, Konstantin" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure Thread-Index: AQHUfQg4Y0nvL0ftLE+UN1MfR0ZZg6VRkEjw Date: Fri, 16 Nov 2018 00:47:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CEB8920@IRSMSX106.ger.corp.intel.com> References: <20181115172427.67607-1-roy.fan.zhang@intel.com> <20181115172427.67607-3-roy.fan.zhang@intel.com> In-Reply-To: <20181115172427.67607-3-roy.fan.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMThhOGMyNmMtOTIwMy00OTg2LTk1OTYtYTdkMzYyNjRlOTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic0xzbkNLbVVKaTRyNFo1bjBBZkNEa0lpZXpkclwvYzVTZ3BtSWFqRk1OVE1nTWtCR255QVZRRlF3SGNjTWV0RzEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 00:47:46 -0000 Hi Fan, > - > /** Cryptodev symmetric crypto session > * Each session is derived from a fixed xform chain. Therefore each sess= ion > * has a fixed algo, key, op-type, digest_len etc. > */ > struct rte_cryptodev_sym_session { > - __extension__ void *sess_private_data[0]; > - /**< Private symmetric session material */ > + uint64_t userdata; > + /**< Can be used for external metadata */ > + uint16_t nb_drivers; > + /**< number of elements in sess_data array */ > + uint16_t priv_size; > + /**< session private data will be placed after sess_data */ > + __extension__ struct { > + void *data; > + uint16_t refcnt; > + } sess_data[0]; > + /**< Driver specific session material, variable size */ > }; >=20 As discussed in the thread [1] to avoid naming collisions, it was agreed to re-name 'userdata' field to 'opaque_data' and 'priv_size' to ' 'user_data_sz'. Konstantin [1] https://mails.dpdk.org/archives/dev/2018-November/118941.html