From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B6F575B3E for ; Mon, 26 Nov 2018 10:56:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2018 01:56:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,281,1539673200"; d="scan'208";a="111351168" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 26 Nov 2018 01:56:27 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.8]) by IRSMSX107.ger.corp.intel.com ([169.254.10.79]) with mapi id 14.03.0415.000; Mon, 26 Nov 2018 09:56:26 +0000 From: "Ananyev, Konstantin" To: "Varghese, Vipin" , Stephen Hemminger CC: "Pattan, Reshma" , "dev@dpdk.org" , "thomas@monjalon.net" , "Mcnamara, John" , "Byrne, Stephen1" , "Glynn, Michael J" , "Patel, Amol" Thread-Topic: [PATCH v4 5/9] app/procinfo: add support for show tm Thread-Index: AQHUhT7DxSutPQTiRki7qeUOKBTbk6VhycOwgAABymCAAAPZAIAAAkEg Date: Mon, 26 Nov 2018 09:56:26 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010CEBC536@IRSMSX106.ger.corp.intel.com> References: <20181106124912.40700-1-vipin.varghese@intel.com> <20181106124912.40700-5-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D58A3@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1435@BGSMSX101.gar.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D61A6@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A45@BGSMSX101.gar.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D6264@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1A79@BGSMSX101.gar.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A3D62FB@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B26@BGSMSX101.gar.corp.intel.com> <20181123092215.50d299ae@xeon-e3> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1FD9@BGSMSX101.gar.corp.intel.com> <2601191342CEEE43887BDE71AB977258010CEBC4DC@IRSMSX106.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258010CEBC50B@IRSMSX106.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C21D4@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C21D4@BGSMSX101.gar.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjM4MzQyYTctNmQyNy00YmE1LTk0YzYtMTRiYzU3N2IxYzVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVm1CTHRsa21IOG9hUE4xMldpR09mMzJrWENPeVRoa3ZNaGY1UlZ6dmVrMHFGcmdBVXh6QUQyc1I3TlR4Z3lvKyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 09:56:30 -0000 Hi Vipin, >=20 > Hi Konstantin, >=20 > > > > > > If the operator is '|' what else except of 'OR' you expect it to be r= emapped? >=20 > Thanks for your correction. I have rerun with logical or >=20 > if ((ret) || (!is_leaf)) > 9a512: 83 bd 3c fd ff ff 00 cmp DWORD PTR [rbp-0x2c4],0x0 > 9a519: 75 7e jne 9a599 > 9a51b: 8b 85 28 fd ff ff mov eax,DWORD PTR [rbp-0x2d8] > 9a521: 85 c0 test eax,eax > 9a523: 74 74 je 9a599 > continue; >=20 > There is no conversion to 'Or' operation here. Thanks for >=20 > > BTW, I am agree with Reshma it has to be '||' here. > Thanks for your opinion, can you share review comments for show_tm for de= bug? Not sure I understand your last sentence... Konstantin