From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 21CD31B8C7 for ; Mon, 17 Dec 2018 12:21:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 03:21:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,365,1539673200"; d="scan'208";a="304448423" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga005.fm.intel.com with ESMTP; 17 Dec 2018 03:21:14 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by IRSMSX104.ger.corp.intel.com ([169.254.5.61]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 11:21:13 +0000 From: "Ananyev, Konstantin" To: "Dumitrescu, Cristian" , "Pattan, Reshma" , "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" CC: "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition Thread-Index: AQHUjjm2Aa3ZqX88DkWLrO3Mc2yE4qV+7o9ggAALzYCAA9e5IA== Date: Mon, 17 Dec 2018 11:21:12 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8BB16D@IRSMSX106.ger.corp.intel.com> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <1544193116-7058-2-git-send-email-reshma.pattan@intel.com> <2601191342CEEE43887BDE71AB977258010D8BA5F8@IRSMSX106.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E81545F@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E81545F@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTNjMWM0MjEtZDA0Ny00ZGQ3LWJlMmUtMDFmY2Y3NjZkZjhlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMnZGcWJyNE1kdDZ4OU9KbjlSbFhVK1FONWFBZkdtbFRiWmdBMk56UE56TTExRFp6Zk1kQ3RoWVVGYVdmVGxnWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 11:21:16 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Saturday, December 15, 2018 12:16 AM > To: Ananyev, Konstantin ; Pattan, Reshma ; dev@dpdk.org; > jerin.jacob@caviumnetworks.com; Singh, Jasvinder > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition >=20 >=20 >=20 > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Friday, December 14, 2018 11:36 PM > > To: Pattan, Reshma ; dev@dpdk.org; > > Dumitrescu, Cristian ; > > jerin.jacob@caviumnetworks.com; Singh, Jasvinder > > > > Cc: Pattan, Reshma > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definitio= n > > > > Hi Reshma, > > > > > diff --git a/lib/librte_eal/common/include/rte_color.h > > b/lib/librte_eal/common/include/rte_color.h > > > new file mode 100644 > > > index 000000000..f4387071b > > > --- /dev/null > > > +++ b/lib/librte_eal/common/include/rte_color.h > > > @@ -0,0 +1,18 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(c) 2018 Intel Corporation > > > + */ > > > + > > > +#ifndef _RTE_COLOR_H_ > > > +#define _RTE_COLOR_H_ > > > + > > > +/** > > > + * Color > > > + */ > > > +enum rte_color { > > > + RTE_COLOR_GREEN =3D 0, /**< Green */ > > > + RTE_COLOR_YELLOW, /**< Yellow */ > > > + RTE_COLOR_RED, /**< Red */ > > > + RTE_COLORS /**< Number of colors */ > > > +}; > > > > Does it really belong to EAL? > > Konstantin > > >=20 > Why not? >=20 > It needs to be visible to multiple libraries: ethdev, meter, sched, as we= ll as drivers. We'd like to avoid adding more complexity to > dependencies between libraries. >=20 > It is very generic. EAL common/include is currently the place to put gene= ric data structures, functions, algs, etc that are widely used by > DPDK libraries. Lots of similar examples are easy to find in this folder. I don't think it is *that* generic to be in EAL. Yes it is used by few libs, ethdev and by softnic PMD, but it doesn't look as core dpdk thing to me. =20 >=20 > Where else would you put it? If it defines format of rte_mbuf fileds, then probably new .h inside librte_mbuf is a good place. Other alternatives would be rte_ethdev or rte_net. Konstantin