From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D779E1B5A4 for ; Tue, 18 Dec 2018 18:07:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 09:07:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,368,1539673200"; d="scan'208";a="127052940" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 18 Dec 2018 09:07:05 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by IRSMSX154.ger.corp.intel.com ([169.254.12.217]) with mapi id 14.03.0415.000; Tue, 18 Dec 2018 17:07:04 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Dumitrescu, Cristian" CC: "Pattan, Reshma" , "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Singh, Jasvinder" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition Thread-Index: AQHUjjm2Aa3ZqX88DkWLrO3Mc2yE4qV+7wMAgAAI+mCAA+DLAIAAYu6AgAAZcACAAEoNAIAAvUWAgAAMebCAABesAIAAC3aAgAAFpYCAADl2oA== Date: Tue, 18 Dec 2018 17:07:03 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8BC0BC@IRSMSX106.ger.corp.intel.com> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <34337288.XBznk5NxM7@xps> <3EB4FA525960D640B5BDFFD6A3D891268E81666F@IRSMSX108.ger.corp.intel.com> <11978750.fjrl6Z7eF7@xps> In-Reply-To: <11978750.fjrl6Z7eF7@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjRhODJlMDEtNTU1MC00ZTI3LWE4ZDUtNmFjNGIzNThiYmYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ3grOFBBS1pvVHVETHAwbHZhV0R1WmpTM2hYMWtVeUFZM2dFclhva3lxM25qemwwXC9cL1JJV25TYzFVOFFaK2wyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 17:07:11 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, December 18, 2018 1:39 PM > To: Dumitrescu, Cristian > Cc: Pattan, Reshma ; dev@dpdk.org; Ananyev, Kons= tantin ; > jerin.jacob@caviumnetworks.com; Singh, Jasvinder ; david.marchand@redhat.com; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition >=20 > 18/12/2018 14:19, Dumitrescu, Cristian: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 18/12/2018 12:18, Dumitrescu, Cristian: > > > > > > I replied in v3 that it should stay in rte_meter.h. > > > > > > You can include rte_meter.h in ethdev. > > > > > > > > > > OK, thanks Thomas, makes sense to me as well. > > > > > > > > > > > > > Thomas, > > > > > > > > I agree with your input, but just want to make sure we are on the s= ame > > > page: > > > > > > > > Besides including rte_meter.h in ethdev (which you are fine with), = we > > > would also need to include rte_meter.h in mbuf. > > > > > > > > Are you OK with this as well? > > > > > > Why do we need rte_meter.h in mbuf? > > > > > > > You probably looked at V2 only, but in V3 we have functions to set/get = the color within the mbuf->hash.sched field. > > > > For space compression reasons, the mbuf->hash.sched stores the color on= 8-bit variable, while for the outside world the set/get functions > work with the 32-bit enum type. We do same thing in other places in DPDK,= such as rte_crypto_op, etc. >=20 > So it's a different discussion. > We need to review this v3 and check how relevant this mbuf API is. >=20 > If the API is accepted, yes the include should not be an issue. Personally, I don't think it is a good idea to add extra dependency for lib= rte_mbuf. I'd prefer either to keep rte_color definition inside librte_mbuf, or move corresponding function definitions out of it. Konstantin