From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 778671B144 for ; Wed, 19 Dec 2018 11:12:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 02:12:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="129107618" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga004.fm.intel.com with ESMTP; 19 Dec 2018 02:12:27 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 19 Dec 2018 10:12:27 +0000 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by irsmsx111.ger.corp.intel.com ([169.254.2.183]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 10:12:26 +0000 From: "Ananyev, Konstantin" To: Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" CC: Chas Williams Thread-Topic: [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes Thread-Index: AQHUhg2MYouwKtt7u0Oh637SWsXOIaWF+kJw Date: Wed, 19 Dec 2018 10:12:25 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8BC664@IRSMSX106.ger.corp.intel.com> References: <20181127045613.16437-1-3chas3@gmail.com> In-Reply-To: <20181127045613.16437-1-3chas3@gmail.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA1ODY2ZDMtMDdlZC00MDhmLThmOGEtYzM4NDQxMmMzYmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU0xcLzFLOEVEbWtJVVBJRnFKbWY0ekxWWGRQWVJFeTMwVHdiZ0NoVU9hQkVHNHZTQ3BSVzQyMEJwaG41N3RBelAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 10:12:29 -0000 > -----Original Message----- > From: Chas Williams [mailto:3chas3@gmail.com] > Sent: Tuesday, November 27, 2018 4:56 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chas Williams > Subject: [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes >=20 > From: Chas Williams >=20 > The same issue was fixed on for the ipv4 version of this routine in > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 bytes"). > Briefly, the size of an ipv6 header is always 40 bytes. With an MTU of > 1500, this will never produce a multiple of 8 bytes for the frag_size > and this routine can never succeed. Since RTE_ASSERTS are disabled by > default, this failure is tpyically ignored. >=20 > To fix this, round down to the nearest 8 bytes and use this when > producing the fragments. >=20 > Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support") >=20 > Signed-off-by: Chas Williams > --- Acked-by: Konstantin Ananyev > 2.14.4