From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking
Date: Wed, 19 Dec 2018 10:56:09 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D8BC760@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <ebc940ff-c50e-94dc-c7a6-9b1eca73ec09@lysator.liu.se>
> -----Original Message-----
> From: Mattias Rönnblom [mailto:hofors@lysator.liu.se]
> Sent: Wednesday, December 19, 2018 10:28 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org
> Cc: nd <nd@arm.com>; Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking
>
> On 2018-12-19 07:37, Honnappa Nagarahalli wrote:
> >> diff --git a/lib/librte_eal/rte_eal_version.map
> >> b/lib/librte_eal/rte_eal_version.map
> >> index 3fe78260d..8b1593dd8 100644
> >> --- a/lib/librte_eal/rte_eal_version.map
> >> +++ b/lib/librte_eal/rte_eal_version.map
> >> @@ -355,6 +355,8 @@ EXPERIMENTAL {
> >> rte_mp_request_async;
> >> rte_mp_sendmsg;
> >> rte_option_register;
> >> + rte_rwlock_read_trylock;
> >> + rte_rwlock_write_trylock;
> > I do not see the other RW lock APIs in this file.
> >
>
> They, just like those added, are static inline functions, will not
> result in any symbols in any shared objects and thus shouldn't be in any
> version.map file.
So, are you guys trying to say that there is no need to put these 'trylock'
functions into 'experimental' section?
Konstantin
next prev parent reply other threads:[~2018-12-19 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 17:27 [dpdk-dev] [PATCH 0/2] Add " Konstantin Ananyev
2018-11-13 17:27 ` [dpdk-dev] [PATCH 1/2] rwlock: introduce " Konstantin Ananyev
2018-12-19 6:37 ` Honnappa Nagarahalli
2018-12-19 8:30 ` Gavin Hu (Arm Technology China)
2018-12-19 10:28 ` Mattias Rönnblom
2018-12-19 10:56 ` Ananyev, Konstantin [this message]
2018-12-19 11:00 ` Bruce Richardson
2018-12-19 12:41 ` Ananyev, Konstantin
2018-12-19 15:11 ` Honnappa Nagarahalli
2018-12-19 16:27 ` Ananyev, Konstantin
2018-11-13 17:27 ` [dpdk-dev] [PATCH 2/2] test: add new test-cases for rwlock autotest Konstantin Ananyev
2018-12-19 8:28 ` Gavin Hu (Arm Technology China)
2018-12-19 2:39 ` [dpdk-dev] [PATCH 0/2] Add 'try' semantics for RD and WR locking Thomas Monjalon
2018-12-19 18:07 ` [dpdk-dev] [PATCH v2 " Konstantin Ananyev
2018-12-19 19:53 ` Thomas Monjalon
2018-12-19 18:07 ` [dpdk-dev] [PATCH v2 1/2] rwlock: introduce " Konstantin Ananyev
2018-12-19 18:07 ` [dpdk-dev] [PATCH v2 2/2] test: add new test-cases for rwlock autotest Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D8BC760@IRSMSX106.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).