From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 571861B57B for ; Wed, 19 Dec 2018 13:42:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 04:42:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="120079140" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 19 Dec 2018 04:41:59 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by IRSMSX102.ger.corp.intel.com ([169.254.2.29]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 12:41:58 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" CC: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Honnappa Nagarahalli" , "dev@dpdk.org" , nd , "Gavin Hu (Arm Technology China)" Thread-Topic: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking Thread-Index: AQHUl4WorlWRDq1zD0mphv6wo4bgmqWF43hQgAABgwCAABvb4A== Date: Wed, 19 Dec 2018 12:41:58 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8BC7F0@IRSMSX106.ger.corp.intel.com> References: <1542130061-3702-1-git-send-email-konstantin.ananyev@intel.com> <1542130061-3702-2-git-send-email-konstantin.ananyev@intel.com> <2601191342CEEE43887BDE71AB977258010D8BC760@IRSMSX106.ger.corp.intel.com> <20181219110011.GA16052@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181219110011.GA16052@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIyMjNkYjAtNzc1Zi00M2FiLWJiYjYtYmY2NmQ0YWQ0ZGM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZkhJMkY0NlwvenBFb0FKdDlySkVyQzNjUkUrWWlNU09iR0I3VGYyRlJhTU13VUZ5eEdGNFRqdk9NNm9mQklTK3kifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 12:42:02 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, December 19, 2018 11:00 AM > To: Ananyev, Konstantin > Cc: Mattias R=F6nnblom ; Honnappa Nagarahalli ; dev@dpdk.org; nd > ; Gavin Hu (Arm Technology China) > Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for= RD and WR locking >=20 > On Wed, Dec 19, 2018 at 10:56:09AM +0000, Ananyev, Konstantin wrote: > > > > > > > -----Original Message----- > > > From: Mattias R=F6nnblom [mailto:hofors@lysator.liu.se] > > > Sent: Wednesday, December 19, 2018 10:28 AM > > > To: Honnappa Nagarahalli ; Ananyev, Kon= stantin ; dev@dpdk.org > > > Cc: nd ; Gavin Hu (Arm Technology China) > > > Subject: Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics= for RD and WR locking > > > > > > On 2018-12-19 07:37, Honnappa Nagarahalli wrote: > > > >> diff --git a/lib/librte_eal/rte_eal_version.map > > > >> b/lib/librte_eal/rte_eal_version.map > > > >> index 3fe78260d..8b1593dd8 100644 > > > >> --- a/lib/librte_eal/rte_eal_version.map > > > >> +++ b/lib/librte_eal/rte_eal_version.map > > > >> @@ -355,6 +355,8 @@ EXPERIMENTAL { > > > >> rte_mp_request_async; > > > >> rte_mp_sendmsg; > > > >> rte_option_register; > > > >> + rte_rwlock_read_trylock; > > > >> + rte_rwlock_write_trylock; > > > > I do not see the other RW lock APIs in this file. > > > > > > > > > > They, just like those added, are static inline functions, will not > > > result in any symbols in any shared objects and thus shouldn't be in = any > > > version.map file. > > > > So, are you guys trying to say that there is no need to put these 'tryl= ock' > > functions into 'experimental' section? > > Konstantin > > > Anything static inline doesn't have a mapfile entry, so there is no issue > there. Ok, if these map entries are not needed, I'll remove them in v2.=20 > However, the APIs themselves, since they are new should probably > have the __rte_experimental attribute marked on them in the code. They do have __rte_experimental attribute in the .h file. Konstantin