From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E41425A for ; Wed, 19 Dec 2018 19:14:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 10:14:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,373,1539673200"; d="scan'208";a="111878963" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 19 Dec 2018 10:14:35 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by irsmsx105.ger.corp.intel.com ([169.254.7.247]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 18:14:34 +0000 From: "Ananyev, Konstantin" To: "Pattan, Reshma" , "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Rao, Nikhil" , "olivier.matz@6wind.com" , "thomas@monjalon.net" , "Singh, Jasvinder" , "Dumitrescu, Cristian" CC: "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field Thread-Index: AQHUl7GSS662w6A1HESYFP59uQQy4qWGXdPQ Date: Wed, 19 Dec 2018 18:14:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8BCB6D@IRSMSX106.ger.corp.intel.com> References: <20181219153418.52747-1-reshma.pattan@intel.com> <20181219154237.836-1-reshma.pattan@intel.com> <20181219154237.836-2-reshma.pattan@intel.com> In-Reply-To: <20181219154237.836-2-reshma.pattan@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjIzNjZkODQtMWI2Ny00ODc5LWI4MTUtMDI5YzE2NmE1NWYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR24yZlg0cjJFYjB6blFRMzk5TzNyZ1drNEpSTFBCZEUxRmpVcVBFOU9XRldvN0xqOTNqMnhWU1I4N3Z6V3h5UyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 18:14:38 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, December 19, 2018 3:43 PM > To: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Rao, Nikhil ; olivier.matz@6wind.com; > thomas@monjalon.net; Singh, Jasvinder ; Dumitr= escu, Cristian > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sch= ed field >=20 > This patch implements the changes proposed in the deprecation > notes [1][2]. >=20 > librte_mbuf changes: > The mbuf::hash::sched field is updated to support generic > definition in line with the ethdev TM and MTR APIs. The new generic > format contains: queue ID, traffic class, color. >=20 > Added public APIs to set and get these new fields to and from mbuf. >=20 > librte_sched changes: > In addtion, following API functions of the sched library have > been modified with an additional parameter of type struct > rte_sched_port to accommodate the changes made to mbuf sched field. > (i)rte_sched_port_pkt_write() > (ii) rte_sched_port_pkt_read_tree_path() >=20 > librte_pipeline, qos_sched UT, qos_sched app are updated > to make use of new changes. >=20 > Also mbuf::hash::txadapter has been added for eventdev txq, > rte_event_eth_tx_adapter_txq_set and rte_event_eth_tx_adapter_txq_get() > are updated to use uses mbuf::hash::txadapter.txq. >=20 > doc: > Release notes updated. > Removed deprecation notice for mbuf::hash::sched and sched API. >=20 > [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html > [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html >=20 > Signed-off-by: Jasvinder Singh > Signed-off-by: Reshma Pattan > Acked-by: Cristian Dumitrescu > --- > v6: added scheduler comment >=20 > v5: > Removed librte_meter from librte_mbuf dependency list. > Changed the mbuf set/get functions to use uint8_t for color. >=20 > v4: converted mbuf::hash::sched as instantiation of rte_mbuf_sched. >=20 > v3: addressed review comments given in the below link. > http://patches.dpdk.org/patch/48587/ > Updated library ABI versioning in meson build. > --- Acked-by: Konstantin Ananyev > 2.17.1