From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BDE771B46D for ; Fri, 4 Jan 2019 10:30:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jan 2019 01:29:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,437,1539673200"; d="scan'208";a="115405995" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 04 Jan 2019 01:29:58 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.116]) by irsmsx110.ger.corp.intel.com ([169.254.15.16]) with mapi id 14.03.0415.000; Fri, 4 Jan 2019 09:29:57 +0000 From: "Ananyev, Konstantin" To: Stephen Hemminger CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session Thread-Index: AQHUo6E98gAOCA6ZQECUen9Z7OgcPqWeQMSAgACXvnA= Date: Fri, 4 Jan 2019 09:29:57 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D8FBDA7@irsmsx105.ger.corp.intel.com> References: <1546010263-16257-2-git-send-email-konstantin.ananyev@intel.com> <1546546586-22009-2-git-send-email-konstantin.ananyev@intel.com> <20190103162537.54bd1647@hermes> In-Reply-To: <20190103162537.54bd1647@hermes> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmUzYWViNjMtZGFlZS00M2EzLWEwOGEtMjM3YzM3NWUxODM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2NFUWRCUGhyTGNjXC9qKytSYng3clk3Tk81NGVwNHo0eWNkb3ViWElHYlwvYXBVNERoOWZuZ0ZQejdSR2dsU0x2In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 09:30:01 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, January 4, 2019 12:26 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; akhil.goyal@nxp.com > Subject: Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata p= ointer into crypto sym session >=20 > On Thu, 3 Jan 2019 20:16:17 +0000 > Konstantin Ananyev wrote: >=20 > > Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. > > That allows upper layer to easily associate some user defined > > data with the session. > > > > Signed-off-by: Konstantin Ananyev > > Acked-by: Fiona Trahe > > Acked-by: Mohammad Abdul Awal > > Acked-by: Declan Doherty > > Acked-by: Akhil Goyal > > --- > > lib/librte_cryptodev/rte_cryptodev.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptode= v/rte_cryptodev.h > > index 4099823f1..009860e7b 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > @@ -954,6 +954,8 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_= t qp_id, > > * has a fixed algo, key, op-type, digest_len etc. > > */ > > struct rte_cryptodev_sym_session { > > + uint64_t opaque_data; > > + /**< Opaque user defined data */ > > __extension__ void *sess_private_data[0]; > > /**< Private symmetric session material */ > > }; >=20 > This will cause ABI breakage. Yes, it surely would. That's why we submitted deprecation notice in 18.11 and got 3 acks for it. Konstantin