From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Noa Ezra <noae@mellanox.com>
Cc: Asaf Penso <asafp@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: support big packets
Date: Fri, 4 Jan 2019 12:25:42 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D8FDE8C@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1545829642-18896-1-git-send-email-noae@mellanox.com>
Hi ,
>
> In some vendors the RX and TX configuration must be the same, therefore
> the MTU size need to be equal to max_rx_pkt_len.
> The MTU is the largest size packet in bytes that can be sent on the
> network, therefore before changing this parameter, the NIC could not
> receive packets larger than 1500 bytes, which is the default MTU size.
> In addition, scatter-gather need to be enabled in order to receive
> frames bigger than mbuf size.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Noa Ezra <noae@mellanox.com>
> ---
> examples/ip_fragmentation/main.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index 17a877d..d294f5f 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -141,6 +141,7 @@ struct lcore_queue_conf {
> .max_rx_pkt_len = JUMBO_FRAME_MAX_SIZE,
> .split_hdr_size = 0,
> .offloads = (DEV_RX_OFFLOAD_CHECKSUM |
> + DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_JUMBO_FRAME),
> },
> .txmode = {
> @@ -892,6 +893,16 @@ struct rte_lpm6_config lpm6_config = {
> dev_info.max_rx_pktlen,
> local_port_conf.rxmode.max_rx_pkt_len);
>
> + /* set the mtu to the maximum received packet size */
> + ret = rte_eth_dev_set_mtu(portid,
> + local_port_conf.rxmode.max_rx_pkt_len);
> + if (ret < 0) {
> + printf("\n");
> + rte_exit(EXIT_FAILURE, "Set MTU failed: "
> + "err=%d, port=%d\n",
> + ret, portid);
> + }
> +
It probably doesn't matter for that particular case, but
shouldn't set_mtu() be done after dev_configure()?
To avoid situation when max_rx_pkt_len will be set by set_mtu()
and then overwritten by dev_configure().
Konstantin
> /* get the lcore_id for this port */
> while (rte_lcore_is_enabled(rx_lcore_id) == 0 ||
> qconf->n_rx_queue == (unsigned)rx_queue_per_lcore) {
> --
> 1.8.3.1
prev parent reply other threads:[~2019-01-04 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 13:08 Noa Ezra
2019-01-04 12:25 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D8FDE8C@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=noae@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).