From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C0D8C1B8C3 for ; Thu, 10 Jan 2019 15:52:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 06:52:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="105584239" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga007.jf.intel.com with ESMTP; 10 Jan 2019 06:52:06 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.116]) by IRSMSX106.ger.corp.intel.com ([169.254.8.161]) with mapi id 14.03.0415.000; Thu, 10 Jan 2019 14:52:05 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "De Lara Guarch, Pablo" Thread-Topic: [PATCH v7 00/10] ipsec: new library for IPsec data-path processing Thread-Index: AQHUqO+//3Zo1fcqVUi57RIB0bSjRKWojssAgAAFJaA= Date: Thu, 10 Jan 2019 14:52:05 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D901C95@irsmsx105.ger.corp.intel.com> References: <1546546586-22009-2-git-send-email-konstantin.ananyev@intel.com> <1547130059-9408-1-git-send-email-konstantin.ananyev@intel.com> <1589360.MiOzkj7FWM@xps> In-Reply-To: <1589360.MiOzkj7FWM@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzE2OWUwMzAtMjc4OS00OTZhLWJkZTMtNTEwMTAyM2M5MDNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicHAzN0k0QllVVURldWpVbWllZlo3d2tkYXJScEJzUkhBYUdOZUErODlRS1FsbWhVKytuYXpSc3NRTW94MGE0eSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 00/10] ipsec: new library for IPsec data-path processing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 14:52:09 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, January 10, 2019 2:25 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo > Subject: Re: [PATCH v7 00/10] ipsec: new library for IPsec data-path proc= essing >=20 > 10/01/2019 15:20, Konstantin Ananyev: > > v6 -> v7 > > - Changes to address Thomas comments: > > bump ABI version > > remove related deprecation notice > > update release notes, ABI changes section >=20 > You did not update the lib versions in the release notes. For 'security: add opaque userdata pointer into security session': 1) removed deprecation notice 2) add ABI change into release note: +* security: New field ``uint64_t opaque_data`` is added into + ``rte_security_session`` structure. That would allow upper layer to easi= ly + associate/de-associate some user defined data with the security session. + 3) Bumbed version in Makefile and meson.build What else needs to be done here? > I think you missed a deprecation notice removal in patch 1. As Pablo noticed that would happen in "cryptodev: update symmetric session"= , this patch will be just dropped from the series. > Have you checked the doxygen warnings in last patch? I think I fixed that in v7, are still seeing them? Konstantin