From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: declare tx prepare api as not experimental
Date: Fri, 11 Jan 2019 13:53:06 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D902A4E@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1547212498-14999-1-git-send-email-david.marchand@redhat.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Friday, January 11, 2019 1:15 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>; arybchenko@solarflare.com
> Subject: [dpdk-dev] [PATCH] ethdev: declare tx prepare api as not experimental
>
> The tx prepare api was introduced at a time when the experimental api
> tag mechanism did not exist yet and is missing the tag.
> However, this api has been there since 17.02 and did not suffer any
> change since its introduction.
>
> Let's just remove the warning from the documentation.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> This has been caught while reviewing the tso support in ovs.
> There seems to be a lot of other incorrectly documentated apis like
> this...
> I will see if I can find an easy way to identify them.
> ---
> lib/librte_ethdev/rte_ethdev.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 1960f3a..76266ad 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -4159,9 +4159,6 @@ static inline int rte_eth_tx_descriptor_status(uint16_t port_id,
> }
>
> /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
> * Process a burst of output packets on a transmit queue of an Ethernet device.
> *
> * The rte_eth_tx_prepare() function is invoked to prepare output packets to be
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.8.3.1
next prev parent reply other threads:[~2019-01-11 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 13:14 David Marchand
2019-01-11 13:30 ` Ferruh Yigit
2019-01-11 13:32 ` Andrew Rybchenko
2019-01-11 13:53 ` Ananyev, Konstantin [this message]
2019-01-11 14:11 ` [dpdk-dev] [PATCH v2] ethdev: declare Tx prepare API " David Marchand
2019-01-11 16:52 ` Ferruh Yigit
2019-01-11 17:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D902A4E@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).