From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <konstantin.ananyev@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5CDAC271; Wed, 16 Jan 2019 10:49:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 01:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,485,1539673200"; d="scan'208";a="135062547" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2019 01:49:29 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.116]) by IRSMSX104.ger.corp.intel.com ([169.254.5.101]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 09:49:28 +0000 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "thomas@monjalon.net" <thomas@monjalon.net>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v3] gro: add missing invalid TCP header length check Thread-Index: AQHUrTTQTi7IyT8X3kCwOYPmo+iaQ6Wxps4A Date: Wed, 16 Jan 2019 09:49:27 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258010D9047CF@irsmsx105.ger.corp.intel.com> References: <1547132768-2384-1-git-send-email-jiayu.hu@intel.com> <1547599533-124469-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1547599533-124469-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTExODY5YTUtNzUyMy00NWZkLTk1NjUtMTM0MmYyNTJmOTE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNTlac1I3ZncwN3hHdzN2UGdobDVZenRiclpNUkw3ZkdzMGdRb1hVcE10NHpUa2pCRUw2cUVcLzVKKzlGVHAyQnUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] gro: add missing invalid TCP header length check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 16 Jan 2019 09:49:32 -0000 > -----Original Message----- > From: Hu, Jiayu > Sent: Wednesday, January 16, 2019 12:46 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; thomas@monjalon.n= et; Hu, Jiayu <jiayu.hu@intel.com>; stable@dpdk.org > Subject: [PATCH v3] gro: add missing invalid TCP header length check >=20 > When the TCP header length of input packets is invalid (i.e., less > than 20 bytes or greater than 60 bytes), check_seq_option() will > access illegal memory area when compare TCP Options, which may > cause a segmentation fault. >=20 > This patch adds missing invalid TCP header length check to avoid > illegal memory accesses. >=20 > Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com> > Tested-by: Yinan Wang <yinan.wang@intel.com> > --- Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > -- > 2.7.4