From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] test: fix build when disabling ipsec library
Date: Thu, 17 Jan 2019 12:20:06 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D90500E@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1547720122-5835-1-git-send-email-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Thursday, January 17, 2019 10:15 AM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] test: fix build when disabling ipsec library
>
> Caught after pulling ipsec then compile in an existing build directory.
>
> Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Did a simple fix, we might want to have something like a _LDLIBS-y
> variable but that's just cosmetic.
>
> ---
> test/test/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/test/test/Makefile b/test/test/Makefile
> index e7c8108..5641a59 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -208,7 +208,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c
> SRCS-$(CONFIG_RTE_LIBRTE_BPF) += test_bpf.c
>
> SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c
> +ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)
> LDLIBS += -lrte_ipsec
> +endif
>
> CFLAGS += -DALLOW_EXPERIMENTAL_API
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.8.3.1
next prev parent reply other threads:[~2019-01-17 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 10:15 David Marchand
2019-01-17 12:20 ` Ananyev, Konstantin [this message]
2019-01-17 23:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D90500E@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=mohammad.abdul.awal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).