From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
Date: Fri, 18 Jan 2019 10:57:16 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D905841@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1988021.QFEkKv4KUp@xps>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, January 17, 2019 10:27 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
>
> 16/01/2019 14:21, Fan Zhang:
> > This patch fixes the inflexible compile issue AESNI-MB PMD.
> > Originally the compile of the PMD will fail if IPSec_MB is
> > not installed in default location.
> >
> > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> > -IMB_HDR = /usr/include/intel-ipsec-mb.h
> > +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
>
> What is the backslash? Looks like a typo.
Wouldn't make get confused without it?
Konstantin
>
> > + $(CC) -E $(EXTRA_CFLAGS) - | grep 'intel-ipsec-mb.h' | \
> > + head -1 | cut -d'"' -f2)
>
> I think the most standard invocation of head is "head -n1".
> You can also use "sed 1q".
>
next prev parent reply other threads:[~2019-01-18 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 13:21 Fan Zhang
2019-01-16 16:48 ` De Lara Guarch, Pablo
2019-01-17 22:26 ` Thomas Monjalon
2019-01-18 10:57 ` Ananyev, Konstantin [this message]
2019-01-18 11:03 ` Thomas Monjalon
2019-01-18 11:55 ` Ananyev, Konstantin
2019-01-21 10:08 ` Zhang, Roy Fan
2019-01-21 15:56 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2019-01-21 22:42 ` Ananyev, Konstantin
2019-01-22 16:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D905841@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).