From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Ravi Kerur <rkerur@gmail.com>, dpdk-dev <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd
Date: Wed, 23 Jan 2019 17:20:40 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <2510395.XNuST6rEQr@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, January 23, 2019 5:11 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: Ravi Kerur <rkerur@gmail.com>; dpdk-dev <dev@dpdk.org>; Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd
>
> 23/01/2019 17:32, Ferruh Yigit:
> > On 3/10/2017 8:58 PM, rkerur at gmail.com (Ravi Kerur) wrote:
> > > This patchset merges l3fwd-acl and l3fwd code into common directory.
> > > Adds config file read option to build LPM and EM tables.
> > >
> > > Ravi Kerur (3):
> > > examples/l3fwd: merge l3fwd-acl code into l3fwd
> > > examples/l3fwd: add config file support for lpm
> > > examples/l3fwd: add config file support for exact
> >
> > Hi Ravi,
> >
> > These l3fwd patches are in patchwork for a long time, I am updating the patchset
> > as rejected, if it is still relevant please send a new version on top of latest
> > repo.
> >
> > Sorry for any inconvenience caused.
> >
> > For reference patches:
> > https://patches.dpdk.org/patch/21696/
> > https://patches.dpdk.org/patch/21695/
> > https://patches.dpdk.org/patch/21697/
> >
> > doc one:
> > https://patches.dpdk.org/patch/24211/
>
> This work was going in the right direction.
>
Totally agree.
> Konstantin, as the maintainer of the ACL library,
> do you think it is worth to keep this example as standalone or merged?
My vote is definitely for merging.
That would give us single l3fwd app with 3 different routing methods
(lpm, hash, acl) selectable at run-time, plus routing tables in config file.
Konstantin
next prev parent reply other threads:[~2019-01-23 17:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 19:47 [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd Ravi Kerur
2017-03-05 19:47 ` [dpdk-dev] [v4 1/3] Merge l3fwd-acl and l3fwd code Ravi Kerur
2017-03-08 21:32 ` [dpdk-dev] [PATCH v5 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Ravi Kerur
2017-03-08 21:32 ` [dpdk-dev] [PATCH v5 1/3] " Ravi Kerur
2017-03-09 10:42 ` Mcnamara, John
2017-03-10 20:58 ` [dpdk-dev] [PATCH v6 0/3] " Ravi Kerur
2017-03-10 20:58 ` [dpdk-dev] [PATCH v6 1/3] " Ravi Kerur
2017-03-10 20:58 ` [dpdk-dev] [PATCH v6 2/3] examples/l3fwd: add config file support for lpm Ravi Kerur
2017-03-10 20:58 ` [dpdk-dev] [PATCH v6 3/3] examples/l3fwd: add config file support for exact Ravi Kerur
2017-06-04 11:14 ` [dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Thomas Monjalon
2019-01-23 16:32 ` Ferruh Yigit
2019-01-23 17:10 ` Thomas Monjalon
2019-01-23 17:20 ` Ananyev, Konstantin [this message]
2019-01-23 17:26 ` Thomas Monjalon
2019-01-23 19:36 ` Ferruh Yigit
2019-01-23 20:27 ` Thomas Monjalon
2019-01-24 9:14 ` Rami Rosen
2017-03-08 21:32 ` [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: add config file support for LPM Ravi Kerur
2017-03-09 10:43 ` Mcnamara, John
2017-03-08 21:32 ` [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM Ravi Kerur
2017-03-09 10:45 ` Mcnamara, John
2017-03-10 0:00 ` Ravi Kerur
2017-03-05 19:47 ` [dpdk-dev] [v4 2/3] LPM config file read option Ravi Kerur
2017-03-06 13:57 ` Mcnamara, John
2017-03-06 14:10 ` Mcnamara, John
2017-03-05 19:47 ` [dpdk-dev] [v4 3/3] EM " Ravi Kerur
2017-03-06 13:42 ` Mcnamara, John
2017-03-06 13:33 ` [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd Mcnamara, John
2017-03-06 23:20 ` Ravi Kerur
2017-03-08 21:50 ` Ravi Kerur
2017-03-09 10:37 ` Mcnamara, John
2017-03-09 10:23 ` Mcnamara, John
2017-03-10 0:07 ` Ravi Kerur
2017-03-14 21:14 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=rkerur@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).