From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BA44F1D7 for ; Wed, 20 Feb 2019 10:35:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 01:35:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,390,1544515200"; d="scan'208";a="148312889" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2019 01:35:03 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.72]) by IRSMSX151.ger.corp.intel.com ([169.254.4.243]) with mapi id 14.03.0415.000; Wed, 20 Feb 2019 09:35:03 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , "dev@dpdk.org" , "thomas@monjalon.net" Thread-Topic: [PATCH v2 4/5] test/bpf: move to examples folder Thread-Index: AQHUyGL8KnwLenZe+EWJt1BDtZbgG6XobgPw Date: Wed, 20 Feb 2019 09:35:02 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258012413B796@irsmsx105.ger.corp.intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> <20190219145308.65668-1-bruce.richardson@intel.com> <20190219145308.65668-5-bruce.richardson@intel.com> In-Reply-To: <20190219145308.65668-5-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiNjEzYjMtZmI5ZC00NTVmLWFmMGMtYzcxMTBmNWE2Zjg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVGV1clNrSEZmdW9pb3VnS1I1WSt2UVJyYkJLWnJEV3NJUFVoUWVqZzF6cHFDa3JKeFwvb3RJMmVsTjQ5d3E1eDkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 09:35:06 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 19, 2019 2:53 PM > To: dev@dpdk.org; thomas@monjalon.net > Cc: Richardson, Bruce ; Ananyev, Konstantin <= konstantin.ananyev@intel.com> > Subject: [PATCH v2 4/5] test/bpf: move to examples folder >=20 > The bpf folder didn't actual contain a test application, but instead > basic examples of BPF code for use with testpmd. Might be the better to create app/test-pmf/bpf directory and move them into it. Konstantin > Therefore we can > move it to the `examples` folder. Being different, it also needs > a README with it, explaining what it is and how to use it. References > to the code from the testpmd docs are suitably updated. >=20 > CC: Konstantin Ananyev > Signed-off-by: Bruce Richardson > --- > MAINTAINERS | 2 +- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++---- > examples/bpf/README | 8 ++++++++ > {test =3D> examples}/bpf/dummy.c | 0 > {test =3D> examples}/bpf/mbuf.h | 0 > examples/bpf/meson.build | 6 ++++++ > {test =3D> examples}/bpf/t1.c | 0 > {test =3D> examples}/bpf/t2.c | 0 > {test =3D> examples}/bpf/t3.c | 0 > 9 files changed, 19 insertions(+), 5 deletions(-) > create mode 100644 examples/bpf/README > rename {test =3D> examples}/bpf/dummy.c (100%) > rename {test =3D> examples}/bpf/mbuf.h (100%) > create mode 100644 examples/bpf/meson.build > rename {test =3D> examples}/bpf/t1.c (100%) > rename {test =3D> examples}/bpf/t2.c (100%) > rename {test =3D> examples}/bpf/t3.c (100%) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index c4619174a..6d1d0aea7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1230,7 +1230,7 @@ F: doc/guides/howto/telemetry.rst > BPF - EXPERIMENTAL > M: Konstantin Ananyev > F: lib/librte_bpf/ > -F: test/bpf/ > +F: examples/bpf/ > F: test/test/test_bpf.c > F: doc/guides/prog_guide/bpf_lib.rst >=20 > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/tes= tpmd_app_ug/testpmd_funcs.rst > index 029148041..b079c60d9 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -4503,20 +4503,20 @@ For example: >=20 > .. code-block:: console >=20 > - cd test/bpf > + cd examples/bpf > clang -O2 -target bpf -c t1.c >=20 > Then to load (and JIT compile) t1.o at RX queue 0, port 1:: >=20 > .. code-block:: console >=20 > - testpmd> bpf-load rx 1 0 J ./dpdk.org/test/bpf/t1.o > + testpmd> bpf-load rx 1 0 J ./dpdk.org/examples/bpf/t1.o >=20 > To load (not JITed) t1.o at TX queue 0, port 0:: >=20 > .. code-block:: console >=20 > - testpmd> bpf-load tx 0 0 - ./dpdk.org/test/bpf/t1.o > + testpmd> bpf-load tx 0 0 - ./dpdk.org/examples/bpf/t1.o >=20 > bpf-unload > ~~~~~~~~~~ > @@ -4529,4 +4529,4 @@ For example to unload BPF filter from TX queue 0, p= ort 0: >=20 > .. code-block:: console >=20 > - testpmd> bpf-load tx 0 0 - ./dpdk.org/test/bpf/t1.o > + testpmd> bpf-unload tx 0 0 > diff --git a/examples/bpf/README b/examples/bpf/README > new file mode 100644 > index 000000000..d714180a5 > --- /dev/null > +++ b/examples/bpf/README > @@ -0,0 +1,8 @@ > +This folder contains example BPF programs for use with the DPDK bpf > +library. To get details of each program and how to compile it, see > +the header on the '.c' file itself. > + > +Once compiled, these example programs can be loaded into `testpmd` > +for execution on a packet stream. See `bpf-load` and `bpf-unload` > +commands documented in the `Testpmd Application User Guide` for > +details on how to do so. > diff --git a/test/bpf/dummy.c b/examples/bpf/dummy.c > similarity index 100% > rename from test/bpf/dummy.c > rename to examples/bpf/dummy.c > diff --git a/test/bpf/mbuf.h b/examples/bpf/mbuf.h > similarity index 100% > rename from test/bpf/mbuf.h > rename to examples/bpf/mbuf.h > diff --git a/examples/bpf/meson.build b/examples/bpf/meson.build > new file mode 100644 > index 000000000..0a817aaea > --- /dev/null > +++ b/examples/bpf/meson.build > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Intel Corporation > + > +# This contains BPF example code for use in testing BPF with testpmd, > +# therefore it should not be built as part of a meson build. > +build=3Dfalse > diff --git a/test/bpf/t1.c b/examples/bpf/t1.c > similarity index 100% > rename from test/bpf/t1.c > rename to examples/bpf/t1.c > diff --git a/test/bpf/t2.c b/examples/bpf/t2.c > similarity index 100% > rename from test/bpf/t2.c > rename to examples/bpf/t2.c > diff --git a/test/bpf/t3.c b/examples/bpf/t3.c > similarity index 100% > rename from test/bpf/t3.c > rename to examples/bpf/t3.c > -- > 2.20.1