From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 00E34F94;
Wed, 6 Mar 2019 11:08:36 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
06 Mar 2019 02:08:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,447,1544515200"; d="scan'208";a="123063501"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
by orsmga008.jf.intel.com with ESMTP; 06 Mar 2019 02:08:34 -0800
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Wed, 6 Mar 2019 10:08:31 +0000
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.72]) by
irsmsx155.ger.corp.intel.com ([169.254.14.230]) with mapi id 14.03.0415.000;
Wed, 6 Mar 2019 10:08:31 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "stable@dpdk.org"
<stable@dpdk.org>
Thread-Topic: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
Thread-Index: AQHU02GwhDCLiJXQZESYkFry5bz3QaX+YhDg
Date: Wed, 6 Mar 2019 10:08:30 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258012414014A@irsmsx105.ger.corp.intel.com>
References: <20190305144041.88771-1-roy.fan.zhang@intel.com>
In-Reply-To: <20190305144041.88771-1-roy.fan.zhang@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTk3MWMxMDEtMTk3MC00OWM3LTkyMzEtNDMyYjU2N2Y2NmQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibkttTFg1Y0hMMTVaV0p3WGoxXC9sV3UyK0JXZzhjZzJVelJaR0JuZ3l4Y0RlMjRvK2VqZFwvNnlmbzhOUVl6QTlqIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ipsec-secgw: fix AES-CTR block size in
legacy mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 10:08:37 -0000
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, March 5, 2019 2:41 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ananye=
v, Konstantin <konstantin.ananyev@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] ipsec-secgw: fix AES-CTR block size in legacy mode
>=20
> This patch fixes the incorrect block size for AES-CTR in
> legacy mode. Originally, wrong block size will cause
> esp_inbound() drop AES-CTR encrypted packets if the payload
> sizes not equal to multiple times of 16.
>=20
> Fixes: 4470c22de2e1 ("examples/ipsec-secgw: add AES-CTR")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ipsec-secgw/sa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 414fcd26c..93e3620bc 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -80,7 +80,7 @@ const struct supported_cipher_algo cipher_algos[] =3D {
> .keyword =3D "aes-128-ctr",
> .algo =3D RTE_CRYPTO_CIPHER_AES_CTR,
> .iv_len =3D 8,
> - .block_size =3D 16, /* XXX AESNI MB limition, should be 4 */
> + .block_size =3D 4,
> .key_len =3D 20
> },
> {
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.14.5