From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv offset
Date: Sat, 6 Apr 2019 12:37:58 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580148A93C8A@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20190405160424.39320-1-roy.fan.zhang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, April 5, 2019 5:04 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv offset
>
> This patch fixes the incorrect iv offset calculation.
>
> Fixes: b063e843fa03 ("crypto/virtio: fix IV physical address")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> fixed a typo
>
> drivers/crypto/virtio/virtio_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/virtio/virtio_rxtx.c b/drivers/crypto/virtio/virtio_rxtx.c
> index e32a1ecd6..e9a63cb5a 100644
> --- a/drivers/crypto/virtio/virtio_rxtx.c
> +++ b/drivers/crypto/virtio/virtio_rxtx.c
> @@ -203,8 +203,8 @@ virtqueue_crypto_sym_enqueue_xmit(
> uint16_t req_data_len = sizeof(struct virtio_crypto_op_data_req);
> uint32_t indirect_vring_addr_offset = req_data_len +
> sizeof(struct virtio_crypto_inhdr);
> - uint32_t indirect_iv_addr_offset = indirect_vring_addr_offset +
> - sizeof(struct vring_desc) * NUM_ENTRY_VIRTIO_CRYPTO_OP;
> + uint32_t indirect_iv_addr_offset =
> + offsetof(struct virtio_crypto_op_cookie, iv);
> struct rte_crypto_sym_op *sym_op = cop->sym;
> struct virtio_crypto_session *session =
> (struct virtio_crypto_session *)get_sym_session_private_data(
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.14.5
next prev parent reply other threads:[~2019-04-06 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 15:31 [dpdk-dev] [PATCH] " Fan Zhang
2019-04-05 15:31 ` Fan Zhang
2019-04-05 16:04 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2019-04-05 16:04 ` Fan Zhang
2019-04-06 12:37 ` Ananyev, Konstantin [this message]
2019-04-06 12:37 ` Ananyev, Konstantin
2019-04-17 7:14 ` Maxime Coquelin
2019-04-17 7:14 ` Maxime Coquelin
2019-04-17 7:57 ` Maxime Coquelin
2019-04-17 7:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580148A93C8A@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).