From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C960A58C6 for ; Tue, 9 Apr 2019 10:41:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 01:41:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,328,1549958400"; d="scan'208";a="162664932" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 09 Apr 2019 01:41:42 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX109.ger.corp.intel.com ([169.254.13.189]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 09:41:42 +0100 From: "Ananyev, Konstantin" To: Aaron Conole , "dev@dpdk.org" CC: Jerin Jacob , Gavin Hu Thread-Topic: [PATCH 3/3] acl: adjust the tests Thread-Index: AQHU7jhOViMjaDjlwE61eucKpeigIKYzgw6w Date: Tue, 9 Apr 2019 08:41:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A94A44@irsmsx105.ger.corp.intel.com> References: <20190408182420.4398-1-aconole@redhat.com> <20190408182420.4398-4-aconole@redhat.com> In-Reply-To: <20190408182420.4398-4-aconole@redhat.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzlhMGFjZjktMjc4Mi00ZmVmLWEyNDMtNjJmN2I2Y2QzMTBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiclRwU21zcldHbnNUZGlMSXQxZ0JFUSs3dDhNVmpTQlZOcEg4OW43Tm9wS3BJa2FKckVtUE9YM1REMG4rVWwxSyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 08:41:45 -0000 Hi Aaron, >=20 > This makes the tests pass, and also ensures that on platforms where the > testing is supported, we can properly test the implementation specific > code. One edge case is when we run on x86_64 systems that don't support > AVX2, but where the compiler can generate such instructions. That could > be an enhancement in the future, but for now at least the tests will > pass. >=20 > Signed-off-by: Aaron Conole > --- > app/test/test_acl.c | 62 +++++++++++++-------------------- > lib/librte_acl/Makefile | 1 + > lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++ > lib/librte_acl/meson.build | 4 +-- > 4 files changed, 73 insertions(+), 40 deletions(-) > create mode 100644 lib/librte_acl/acl_run_notsup.c >=20 > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > index b1f75d1bc..c44faa251 100644 > --- a/app/test/test_acl.c > +++ b/app/test/test_acl.c > @@ -408,6 +408,9 @@ test_classify(void) > return -1; > } >=20 > + /* Always use the scalar testing for now. */ > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > + > ret =3D 0; > for (i =3D 0; i !=3D TEST_CLASSIFY_ITER; i++) { >=20 > @@ -547,6 +550,7 @@ test_build_ports_range(void) > for (i =3D 0; i !=3D RTE_DIM(test_data); i++) > data[i] =3D (uint8_t *)&test_data[i]; >=20 > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > for (i =3D 0; i !=3D RTE_DIM(test_rules); i++) { > rte_acl_reset(acx); > ret =3D test_classify_buid(acx, test_rules, i + 1); > @@ -911,6 +915,8 @@ test_convert_rules(const char *desc, > return -1; > } >=20 > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > + As I understand here and above, on x86 you replaced default algo (SSE, AVX2= ) with scalar one, right? That looks like reduction of test coverage for x86. Konstantin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B4980A0096 for ; Tue, 9 Apr 2019 10:41:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3EBE58EC; Tue, 9 Apr 2019 10:41:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C960A58C6 for ; Tue, 9 Apr 2019 10:41:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 01:41:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,328,1549958400"; d="scan'208";a="162664932" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 09 Apr 2019 01:41:42 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX109.ger.corp.intel.com ([169.254.13.189]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 09:41:42 +0100 From: "Ananyev, Konstantin" To: Aaron Conole , "dev@dpdk.org" CC: Jerin Jacob , Gavin Hu Thread-Topic: [PATCH 3/3] acl: adjust the tests Thread-Index: AQHU7jhOViMjaDjlwE61eucKpeigIKYzgw6w Date: Tue, 9 Apr 2019 08:41:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A94A44@irsmsx105.ger.corp.intel.com> References: <20190408182420.4398-1-aconole@redhat.com> <20190408182420.4398-4-aconole@redhat.com> In-Reply-To: <20190408182420.4398-4-aconole@redhat.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzlhMGFjZjktMjc4Mi00ZmVmLWEyNDMtNjJmN2I2Y2QzMTBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiclRwU21zcldHbnNUZGlMSXQxZ0JFUSs3dDhNVmpTQlZOcEg4OW43Tm9wS3BJa2FKckVtUE9YM1REMG4rVWwxSyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409084141.DSbnS1XDFwH4KzVDqbIWF5lshmp7nbT9Fk2a0Nos3f0@z> Hi Aaron, >=20 > This makes the tests pass, and also ensures that on platforms where the > testing is supported, we can properly test the implementation specific > code. One edge case is when we run on x86_64 systems that don't support > AVX2, but where the compiler can generate such instructions. That could > be an enhancement in the future, but for now at least the tests will > pass. >=20 > Signed-off-by: Aaron Conole > --- > app/test/test_acl.c | 62 +++++++++++++-------------------- > lib/librte_acl/Makefile | 1 + > lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++ > lib/librte_acl/meson.build | 4 +-- > 4 files changed, 73 insertions(+), 40 deletions(-) > create mode 100644 lib/librte_acl/acl_run_notsup.c >=20 > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > index b1f75d1bc..c44faa251 100644 > --- a/app/test/test_acl.c > +++ b/app/test/test_acl.c > @@ -408,6 +408,9 @@ test_classify(void) > return -1; > } >=20 > + /* Always use the scalar testing for now. */ > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > + > ret =3D 0; > for (i =3D 0; i !=3D TEST_CLASSIFY_ITER; i++) { >=20 > @@ -547,6 +550,7 @@ test_build_ports_range(void) > for (i =3D 0; i !=3D RTE_DIM(test_data); i++) > data[i] =3D (uint8_t *)&test_data[i]; >=20 > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > for (i =3D 0; i !=3D RTE_DIM(test_rules); i++) { > rte_acl_reset(acx); > ret =3D test_classify_buid(acx, test_rules, i + 1); > @@ -911,6 +915,8 @@ test_convert_rules(const char *desc, > return -1; > } >=20 > + rte_acl_set_ctx_classify(acx, RTE_ACL_CLASSIFY_SCALAR); > + As I understand here and above, on x86 you replaced default algo (SSE, AVX2= ) with scalar one, right? That looks like reduction of test coverage for x86. Konstantin