From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7C6C4A0471 for ; Thu, 20 Jun 2019 16:29:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4368C2AA0; Thu, 20 Jun 2019 16:29:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0F0C31D3F3 for ; Thu, 20 Jun 2019 16:29:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 07:29:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,397,1557212400"; d="scan'208";a="154128568" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga008.jf.intel.com with ESMTP; 20 Jun 2019 07:29:13 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.143]) by IRSMSX107.ger.corp.intel.com ([169.254.10.205]) with mapi id 14.03.0439.000; Thu, 20 Jun 2019 15:29:13 +0100 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" Thread-Topic: [PATCH v2] ipsec: support multi-segment packets Thread-Index: AQHVF0PoVBcPWABZSkKbRwCcQ3irSaakjQMAgAAoA5A= Date: Thu, 20 Jun 2019 14:29:12 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725801689E2B8D@IRSMSX104.ger.corp.intel.com> References: <20190527182328.12143-1-konstantin.ananyev@intel.com> <20190531000006.13918-1-konstantin.ananyev@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTc4Yzc2NTctZmZjYS00MTk3LTk5ODUtZTA5ZDI1YTNlNWFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibWNNalJaQ2dCUFloNm9EOHRuYXRaSU43MWtcLzdod0ZGTjV1R3hwVnBzSHgyMm9DOEdQa0tmR2NNTUR0OHVoM3UifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ipsec: support multi-segment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > Hi Konstantin, >=20 > > > > Add support for packets that consist of multiple segments. > > Take into account that trailer bytes (padding, ESP tail, ICV) > > can spawn across multiple segments. > > > > Signed-off-by: Konstantin Ananyev > > --- >=20 > Which all action types does this patch work well with? > Will it work for lookaside none and inline crypto case both? Yes, in theory it should work with any device that supports in-place SGL.=20 On practice, right now I am not aware about inline-crypto devices that can support such feature. So far, tested with lookaside-none device.=20 > For the other 2, ipsec lib is not used. In fact, ipsec lib can be used by all 4 cases I believe. Though as I udenstand for lookaside-proto and inline-proto nothing need to be added/changed inside the lib (as HW supposed to deal with it transparently). >=20 > Also how can the SG support be tested? Here is a separate patch series that adds fragmentation/reassembly support into ipsec-secgw and updates test-scripts with new test-cases:=20 http://patches.dpdk.org/cover/54491/ >=20 > > > > v1 -> v2: > > merge with latest mainline > > fix build problem for RTE_BUILD_SHARED_LIB=3Dy > > update programmer's guide > > > > doc/guides/prog_guide/ipsec_lib.rst | 1 - > > lib/librte_ipsec/Makefile | 3 +- > > lib/librte_ipsec/esp_inb.c | 148 +++++++++++++++++++++------- > > lib/librte_ipsec/misc.h | 61 ++++++++++++ > > 4 files changed, 175 insertions(+), 38 deletions(-) > > > > diff --git a/doc/guides/prog_guide/ipsec_lib.rst > > b/doc/guides/prog_guide/ipsec_lib.rst > > index 6fc08886f..63b75b652 100644 > > --- a/doc/guides/prog_guide/ipsec_lib.rst > > +++ b/doc/guides/prog_guide/ipsec_lib.rst > > @@ -162,7 +162,6 @@ Limitations > > The following features are not properly supported in the current versi= on: > > > > * ESP transport mode for IPv6 packets with extension headers. > > -* Multi-segment packets. > > * Updates of the fields in inner IP header for tunnel mode > > (as described in RFC 4301, section 5.1.2). > > * Hard/soft limit for SA lifetime (time interval/byte count). > > diff --git a/lib/librte_ipsec/Makefile b/lib/librte_ipsec/Makefile > > index e80926baa..22f29d98a 100644 > > --- a/lib/librte_ipsec/Makefile > > +++ b/lib/librte_ipsec/Makefile > > @@ -9,7 +9,8 @@ LIB =3D librte_ipsec.a > > CFLAGS +=3D -O3 > > CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) > > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > -LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_net -lrte_cryptodev -lrte_secur= ity > > +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_mbuf -lrte_net > > +LDLIBS +=3D -lrte_cryptodev -lrte_security > > >=20 > I believe this build dependency should also be updated in meson.build fil= e as well. I found that unnecessary, meson seems to be able to figure out implicit dep= endencies itself. Though if you strongly insist, I can add them. Konstantin