From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88419A046B for ; Thu, 25 Jul 2019 09:54:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0F4B1C29C; Thu, 25 Jul 2019 09:54:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 905D01C295 for ; Thu, 25 Jul 2019 09:54:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 00:54:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,306,1559545200"; d="scan'208";a="171735251" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga007.fm.intel.com with ESMTP; 25 Jul 2019 00:54:42 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX101.ger.corp.intel.com ([169.254.1.88]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 08:54:41 +0100 From: "Ananyev, Konstantin" To: Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag Thread-Index: AQHVQq4PevkKSb14R0C5vLj/+78NFaba9ltQ Date: Thu, 25 Jul 2019 07:54:40 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A5AE5D@irsmsx105.ger.corp.intel.com> References: <1564033810-15715-1-git-send-email-skori@marvell.com> <1564034330-16321-1-git-send-email-skori@marvell.com> In-Reply-To: <1564034330-16321-1-git-send-email-skori@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjQzYWFjMDEtOTI4NC00MjdmLThlMmMtN2JmMWJiNjJjNzVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiazlKRGtwdzduTExPVEJ5aGJ0RE9NSlk4RFQxQmlUeHpnOTEzeG1CekRwWEd1WmFWRmlBRVJHcFd2OWlkUHVYdSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sunil Kumar Kori [mailto:skori@marvell.com] > Sent: Thursday, July 25, 2019 6:59 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FR= EE flag >=20 > Application uses different pool to allocate direct and indirect > mbufs which are further spliced together to consturct a fragmented > packet and same is transmitted over the port which is configured > with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments > must belong to the same pool. But constructed packet violates > the conditions. >=20 > So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device > configuration. >=20 > Signed-off-by: Sunil Kumar Kori > --- > v2: > - Subject is corrected. >=20 > examples/ip_fragmentation/main.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation= /main.c > index 03be0c1..324d607 100644 > --- a/examples/ip_fragmentation/main.c > +++ b/examples/ip_fragmentation/main.c > @@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config =3D { > n_tx_queue =3D nb_lcores; > if (n_tx_queue > MAX_TX_QUEUE_PER_PORT) > n_tx_queue =3D MAX_TX_QUEUE_PER_PORT; > - if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > - local_port_conf.txmode.offloads |=3D > - DEV_TX_OFFLOAD_MBUF_FAST_FREE; > ret =3D rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue, > &local_port_conf); > if (ret < 0) { > -- Acked-by: Konstantin Ananyev > 1.8.3.1