From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81897A10DA for ; Wed, 31 Jul 2019 10:22:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B1E51BEBA; Wed, 31 Jul 2019 10:22:23 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 05FC61B956; Wed, 31 Jul 2019 10:22:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 01:22:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,329,1559545200"; d="scan'208";a="323655806" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga004.jf.intel.com with ESMTP; 31 Jul 2019 01:22:19 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX154.ger.corp.intel.com ([169.254.12.160]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 09:22:18 +0100 From: "Ananyev, Konstantin" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue Thread-Index: AQHVRsBMl0YRp+okoUyFPNallSvlK6bj/nqAgABPm0CAAAUogIAAEQ8Q Date: Wed, 31 Jul 2019 08:22:18 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A5FE66@irsmsx105.ger.corp.intel.com> References: <20190730101927.1665-1-konstantin.ananyev@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D399F1E@BGSMSX101.gar.corp.intel.com> <2601191342CEEE43887BDE71AB9772580168A5FD47@irsmsx105.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D39A259@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D39A259@BGSMSX101.gar.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQzYmRkNzEtYWFiNi00YTZmLTk3OTItZGM3MjA5MjljMGRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQzl4bXVQOXh1T29kQmc0VUFKaGtiNm9sVkZkS1wvSnJhZis4dVhieVhRSjhlUlpNQzB3OTdkOVg5UWRwSUQxZkMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Varghese, Vipin > Sent: Wednesday, July 31, 2019 9:20 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/bpf: fix compilation issue >=20 > Snipped >=20 > > > > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are > > > > failing to compile with latest dpdk.org master. > > > > > > As a note, the file t3.c is one which fails to get compiled. > > > > t2.c also uses rte_mbuf, so same story for both. >=20 > Thank you. So, the rewrite will be ' Example BPF programs t2.c, and t3.c = in folder examples/bpf are failing to compile with latest dpdk.org > master.' >=20 > > > > > > > > > The reason is changes in some core DPDK header files, that causes > > > > now inclusion of x86 specific headers. > > > > > > snipped > > > > > > > > > > > > > > #include > > > > #include > > > > -#include > > > > > > > > #ifdef __cplusplus > > > > extern "C" { > > > > @@ -364,6 +363,23 @@ typedef struct { > > > > volatile int16_t cnt; /**< An internal counter value. */ } > > > > rte_atomic16_t; > > > > > > > > +#define RTE_CACHE_LINE_MIN_SIZE 64 /**< Minimum Cache line si= ze. > > */ > > > > > > The definition for RTE_CACHE_LINE_MIN_SIZE is present in ` rte_config= .h`. > > > > I believe it is not: > > $ find lib config -type f | xargs grep CACHE_LINE_MIN_SIZE > > lib/librte_eal/linux/eal/include/rte_kni_common.h:#define > > RTE_CACHE_LINE_MIN_SIZE 64 > > lib/librte_eal/linux/eal/include/rte_kni_common.h: char pad3[8] > > __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE))); > > lib/librte_eal/common/include/rte_memory.h:#define > > RTE_CACHE_LINE_MIN_SIZE 64 /**< Minimum Cache line size. */ > > lib/librte_eal/common/include/rte_memory.h:#define > > __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE) > > > > Konstantin >=20 > Thanks. So, is not the best approach to place RTE_CACHE_LINE_MIN_SIZE in = rte_config.h to prevent multiple definition > (rte_kni_common.h, rte_memory.h and examples/bpf/mbuf.h)? Probably, but I don't want to touch rte_common.h in RC4. Konstantin