From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE60EA00E6 for ; Tue, 6 Aug 2019 11:20:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7AE81BE23; Tue, 6 Aug 2019 11:20:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6CD2D1BE22 for ; Tue, 6 Aug 2019 11:20:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 02:20:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="373993735" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 06 Aug 2019 02:20:25 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX106.ger.corp.intel.com ([169.254.8.234]) with mapi id 14.03.0439.000; Tue, 6 Aug 2019 10:20:24 +0100 From: "Ananyev, Konstantin" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "Hunt, David" , "Kovacevic, Marko" , "Ori Kam" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "Nicolau, Radu" , Akhil Goyal , "Kantecki, Tomasz" , "Mcnamara, John" , "Van Haaren, Harry" , "Li, Xiaoyun" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload Thread-Index: AQHVTC1UKQABdEy8oU+AVMyFxt8O/qbt1uPw Date: Tue, 6 Aug 2019 09:20:23 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A62840@irsmsx105.ger.corp.intel.com> References: <20190806080206.1572-1-pbhagavatula@marvell.com> <20190806080206.1572-4-pbhagavatula@marvell.com> In-Reply-To: <20190806080206.1572-4-pbhagavatula@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTdlMmRhYWItYTlhZC00Yzg3LWIyOTMtMTYxZTE3OGViY2FlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWlhPcWhIVG1WMVFpdkljTHJUTnJyYTN4a0tMakY0ejVLQzFjNHJjZG0wb1VkSytuaWFnRTEzWGlsYTI2SUNrTyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: pbhagavatula@marvell.com [mailto:pbhagavatula@marvell.com] > Sent: Tuesday, August 6, 2019 9:02 AM > To: jerinj@marvell.com; Ananyev, Konstantin ; Hunt, David ; Kovacevic, Marko > ; Ori Kam ; Richardson, Br= uce ; De Lara Guarch, Pablo > ; Nicolau, Radu ;= Akhil Goyal ; Kantecki, Tomasz > ; Mcnamara, John ; Va= n Haaren, Harry ; Li, > Xiaoyun > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload >=20 > From: Pavan Nikhilesh >=20 > Add DEV_RX_OFFLOAD_PTYPE as a offload requirement for applicable > examples. >=20 > Signed-off-by: Pavan Nikhilesh > --- > examples/ip_fragmentation/main.c | 7 +++++++ > examples/l3fwd-power/main.c | 8 ++++++++ > examples/l3fwd/main.c | 9 +++++++++ > examples/performance-thread/l3fwd-thread/main.c | 9 +++++++++ > examples/tep_termination/vxlan_setup.c | 1 + > 5 files changed, 34 insertions(+) >=20 > diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation= /main.c > index 324d60773..2a9895542 100644 > --- a/examples/ip_fragmentation/main.c > +++ b/examples/ip_fragmentation/main.c > @@ -904,6 +904,13 @@ main(int argc, char **argv) >=20 > /* limit the frame size to the maximum supported by NIC */ > rte_eth_dev_info_get(portid, &dev_info); > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_PTYPE) > + local_port_conf.rxmode.offloads |=3D DEV_RX_OFFLOAD_PTYPE; > + > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > + local_port_conf.txmode.offloads |=3D > + DEV_TX_OFFLOAD_MBUF_FAST_FREE; I didn't look at the rest of the patch series yet, but these 3 lines above = seems wrong. and not related to that subject.=20 Probably something wrong with your merge process. Check commit ed553e3db4a84af0ddac0d898476333d61adb93a Author: Sunil Kumar Kori Date: Thu Jul 25 13:54:10 2019 +0530 examples/ip_frag: remove Tx fast free offload flag > local_port_conf.rxmode.max_rx_pkt_len =3D RTE_MIN( > dev_info.max_rx_pktlen, > local_port_conf.rxmode.max_rx_pkt_len); > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index fd8d9528f..875d60c06 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -2261,6 +2261,14 @@ main(int argc, char **argv) > dev_rxq_num =3D dev_info.max_rx_queues; > dev_txq_num =3D dev_info.max_tx_queues; >=20 > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_PTYPE) { > + if (!parse_ptype) > + port_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_PTYPE; > + } else { > + parse_ptype =3D 1; > + } > + > nb_rx_queue =3D get_port_n_rx_queues(portid); > if (nb_rx_queue > dev_rxq_num) > rte_exit(EXIT_FAILURE, > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 3800bad19..dfee880a0 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -875,6 +875,15 @@ main(int argc, char **argv) > nb_rx_queue, (unsigned)n_tx_queue ); >=20 > rte_eth_dev_info_get(portid, &dev_info); > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_PTYPE) { > + if (!parse_ptype) > + local_port_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_PTYPE; > + } else { > + parse_ptype =3D 1; > + } > + > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > local_port_conf.txmode.offloads |=3D > DEV_TX_OFFLOAD_MBUF_FAST_FREE; > diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/p= erformance-thread/l3fwd-thread/main.c > index 49d942407..f033326be 100644 > --- a/examples/performance-thread/l3fwd-thread/main.c > +++ b/examples/performance-thread/l3fwd-thread/main.c > @@ -3560,6 +3560,15 @@ main(int argc, char **argv) > printf("Creating queues: nb_rxq=3D%d nb_txq=3D%u... ", > nb_rx_queue, (unsigned)n_tx_queue); > rte_eth_dev_info_get(portid, &dev_info); > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_PTYPE) { > + if (!parse_ptype_on) > + port_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_PTYPE; > + } else { > + parse_ptype_on =3D 1; > + } > + > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > local_port_conf.txmode.offloads |=3D > DEV_TX_OFFLOAD_MBUF_FAST_FREE; > diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termin= ation/vxlan_setup.c > index 9a0880002..3d2acecd5 100644 > --- a/examples/tep_termination/vxlan_setup.c > +++ b/examples/tep_termination/vxlan_setup.c > @@ -69,6 +69,7 @@ uint8_t tep_filter_type[] =3D {RTE_TUNNEL_FILTER_IMAC_T= ENID, > static struct rte_eth_conf port_conf =3D { > .rxmode =3D { > .split_hdr_size =3D 0, > + .offloads =3D DEV_RX_OFFLOAD_PTYPE, > }, > .txmode =3D { > .mq_mode =3D ETH_MQ_TX_NONE, > -- > 2.17.1