From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E5AA00E6 for ; Thu, 8 Aug 2019 11:23:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A957D1B954; Thu, 8 Aug 2019 11:23:27 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 520F24C94 for ; Thu, 8 Aug 2019 11:23:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 02:23:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="203508447" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2019 02:23:22 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX103.ger.corp.intel.com ([169.254.3.45]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 10:23:21 +0100 From: "Ananyev, Konstantin" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "stephen@networkplumber.org" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags Thread-Index: AQHVTceV2pPltlQueEKmYkOKhhENaqbw9/aQ Date: Thu, 8 Aug 2019 09:23:21 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A63989@irsmsx105.ger.corp.intel.com> References: <20190808081752.516-1-pbhagavatula@marvell.com> <20190808085859.796-1-pbhagavatula@marvell.com> In-Reply-To: <20190808085859.796-1-pbhagavatula@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTdiZjI5Y2YtNjI4My00Mzk3LTk5ZWItMzYyOWNmMDk1YzAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNlgzMGVLWFVabUtJNG5WN3JmXC94ZXhIOHhJbDRpbkVaaW9PeFV3bnMzcXdoT0NCVk12OXNlTnJHRkJoUEpBUkUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [patch v3] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi guys, >=20 > From: Pavan Nikhilesh >=20 > Add new offload flags ``DEV_RX_OFFLOAD_PTYPE``, ``DEV_RX_OFFLOAD_RSS`` > and ``DEV_RX_OFFLOAD_FLOW_MARK``. >=20 > Signed-off-by: Pavan Nikhilesh > Acked-by: Andrew Rybchenko > Acked-by: Jerin Jacob > --- > v3 Changes: > - DEV_RX_OFFLOAD_RSS -> DEV_RX_OFFLOAD_RSS_HASH (anndrew). >=20 > v2 Changes: > - Reword for clarity. >=20 > doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index 37b8592b6..056c5709f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,16 @@ Deprecation Notices > to set new power environment if power environment was already initiali= zed. > In this case the function will return -1 unless the environment is uns= et first > (using ``rte_power_unset_env``). Other function usage scenarios will n= ot change. > + > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_PTYPE``, ``DEV_RX_OFFLOAD_R= SS_HASH`` > + and ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. One question about DEV_RX_OFFLOAD_PTYPE: Does it mean that new ol_flags value (PKT_RX_PTYPE) will be introduced to indicate that mbuf.packet_type value is set? Or PMD will have to set mbuf.packet_type to zero, when DEV_RX_OFFLOAD_PTYPE was not enabled by user? If so, what is the advantage? Again in that case, would it be more plausible to introduce something like: rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t ptype_mask); instead of DEV_RX_OFFLOAD_PTYPE? Konstantin > + This will allow application to enable or disable PMDs from updating > + ``rte_mbuf`` fields ``rte_mbuf::packet_type``, ``rte_mbuf::hash::rss``= and > + ``rte_mbuf::hash::fdir`` respectively. > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on = Rx and > + thereby improve Rx performance if application wishes do so. > + In 19.11 PMDs will still update the fields even when the offloads are = not > + enabled. > + The exact semantics of the flags will be worked out later either by ma= king > + them negative offloads to avoid application change or positive offload= to > + align with existing offload flag semantics. > -- > 2.17.1