From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7E619A2EDB
	for <public@inbox.dpdk.org>; Tue,  1 Oct 2019 19:30:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5EAA71BE0C;
	Tue,  1 Oct 2019 19:30:40 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9128B4C9D
 for <dev@dpdk.org>; Tue,  1 Oct 2019 19:30:38 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Oct 2019 10:30:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,571,1559545200"; d="scan'208";a="366408417"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga005.jf.intel.com with ESMTP; 01 Oct 2019 10:30:36 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.123]) with mapi id 14.03.0439.000;
 Tue, 1 Oct 2019 18:30:35 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Thread-Topic: [PATCH v2 0/3] examples/ipsec-secgw: set default
Thread-Index: AQHVeGt1PghzvMyi1UGof2wAAdzVAqdGCrQA
Date: Tue, 1 Oct 2019 17:30:35 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258019196F5A6@irsmsx105.ger.corp.intel.com>
References: <1567069173-10505-1-git-send-email-bernard.iremonger@intel.com>
 <1569943080-20228-1-git-send-email-bernard.iremonger@intel.com>
In-Reply-To: <1569943080-20228-1-git-send-email-bernard.iremonger@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjcxY2RkOTQtMzkzYS00NTQ1LWE5ZGEtOTAwNTBjNjNlY2EwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUdSVWVpcFFic3RwalVZbE8xbTBDM2NFdUxBRXUxVU9lUUhNdDQ0c0RcL1NCa0FLcGFqUklmOGx1XC9tN2RET0g3In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


Hi Bernard,

>=20
> This patch set, sets the default code path in the ipsec-secgw
> application to use the librte_ipsec.
> The *_old test scripts have been modified to use the legacy code
> path.
>=20
> Changes in v2:
> -------------
> The error messages for the -l option have been updated.
> The pktest.sh script has been updated to drop the -l option.

The patches looks good to me.
Just one thing - shouldn't we also update the docs (AG for ipsec-secgw)?
Konstantin

>=20
> Bernard Iremonger (3):
>   examples/ipsec-secgw: set default to IPsec library mode
>   examples/ipsec-secgw: add -l 0 parameter to old scripts
>   examples/ipsec-secgw: update pktest.sh script
>=20
>  doc/guides/rel_notes/release_19_11.rst             |  8 ++++
>  doc/guides/sample_app_ug/ipsec_secgw.rst           |  6 ++-
>  examples/ipsec-secgw/ipsec-secgw.c                 | 46 ++++++++++++++--=
------
>  examples/ipsec-secgw/test/pkttest.sh               |  1 -
>  .../ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh  |  2 +-
>  .../ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh   |  2 +-
>  .../ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh   |  2 +-
>  .../test/trs_aesgcm_inline_crypto_old_defs.sh      |  2 +-
>  examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh   |  2 +-
>  .../ipsec-secgw/test/tun_3descbc_sha1_old_defs.sh  |  2 +-
>  .../ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh   |  2 +-
>  .../ipsec-secgw/test/tun_aesctr_sha1_old_defs.sh   |  2 +-
>  .../test/tun_aesgcm_inline_crypto_old_defs.sh      |  2 +-
>  examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh   |  2 +-
>  14 files changed, 52 insertions(+), 29 deletions(-)
>=20
> --
> 2.7.4