From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B040CA3295 for ; Wed, 23 Oct 2019 13:12:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E22311C029; Wed, 23 Oct 2019 13:12:27 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3F1A81BFCA for ; Wed, 23 Oct 2019 13:12:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 04:12:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,220,1569308400"; d="scan'208";a="223147908" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga004.fm.intel.com with ESMTP; 23 Oct 2019 04:12:23 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.252]) by IRSMSX103.ger.corp.intel.com ([169.254.3.139]) with mapi id 14.03.0439.000; Wed, 23 Oct 2019 12:12:22 +0100 From: "Ananyev, Konstantin" To: Olivier Matz , Honnappa Nagarahalli CC: "sthemmin@microsoft.com" , "jerinj@marvell.com" , "Richardson, Bruce" , "david.marchand@redhat.com" , "pbhagavatula@marvell.com" , "drc@linux.vnet.ibm.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" , "dharmik.thakkar@arm.com" , "ruifeng.wang@arm.com" , "gavin.hu@arm.com" Thread-Topic: [RFC v6 3/6] test/ring: add functional tests for configurable element size ring Thread-Index: AQHVh6Xp69mWbv5p6UGzyPgFTzC6eqdn8YGAgAAj9bA= Date: Wed, 23 Oct 2019 11:12:21 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725801A8C6E8BC@IRSMSX104.ger.corp.intel.com> References: <20190906190510.11146-1-honnappa.nagarahalli@arm.com> <20191021002300.26497-1-honnappa.nagarahalli@arm.com> <20191021002300.26497-4-honnappa.nagarahalli@arm.com> <20191023100105.GE25286@glumotte.dev.6wind.com> In-Reply-To: <20191023100105.GE25286@glumotte.dev.6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjEzYzAxZWQtMzQ1My00MjJlLThmNDEtMDA1NGIxYTY3NmU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR0o3czFsT1djMzZQREkzSzJCd2xaN1hJZlZsclVoa3dQZGtPV2dzaFNqRCs1R0xYQU5oUEwxUUpXcDBENERqTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v6 3/6] test/ring: add functional tests for configurable element size ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Sun, Oct 20, 2019 at 07:22:57PM -0500, Honnappa Nagarahalli wrote: > > Add functional tests for rte_ring_xxx_elem APIs. At this point these > > are derived mainly from existing rte_ring_xxx test cases. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > app/test/Makefile | 1 + > > app/test/meson.build | 1 + > > app/test/test_ring_elem.c | 859 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 861 insertions(+) > > create mode 100644 app/test/test_ring_elem.c >=20 > Given the few differences between test_ring_elem.c and test_ring.c, would= n't > it be possible to have both tests in the same file? +1 to reduce duplication... Might be move common code into .h file and have actual enqueue/dequeue calls as defines.=20