Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi Daniel,

Good catch :)
We plan to deliver a fix for that bug in coming DPDK release.
It is very similar to yours one, though we need extra check that there are no VFs enabled for that port.
Thanks
Konstantin 

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Monday, January 13, 2014 10:31 AM
To: Daniel Kan
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode

Hello,

11/01/2014 03:46, Daniel Kan:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1546,6 +1546,9 @@ init_port_config(void)
>  		if (nb_rxq > 0) {
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
> +			if (nb_rxq > 1 && rss_hf != 0) {
> +				port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
> +			}

The fix looks good. Thanks.

Please, could you add a detailed explanation and a signed-off as described in the guidelines:
	http://dpdk.org/dev#send

I think it's a good idea to point to the commit which has introduced the bug.
Note also that "RSS rx" may be simply "RSS".

Thank you
--
Thomas
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.