Re: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi,
Can the patch be reworked to keep changes under librte_pmd_ixgbe/ixgbe directory untouched?
Those files are derived directly from the BSD driver baseline, and any changes will make future merges of newer code more challenging.
The changes should be limited to files in the librte_pmd_ixgbe directory (and ethdev).
Thanks
Konstantin

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
Sent: Wednesday, February 19, 2014 11:59 AM
To: thomas.monjalon@6wind.com
Subject: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization

It may happen that DPDK application gets killed while having acquired locks on the ethernet hardware, causing these locks to be never released. On next restart of the application, DPDK skip those ports because it can not acquire the lock, this may cause some ports (or even complete board if SMBI is locked) to be inaccessible from DPDK application until reboot of the hardware.

This patch release locks that are supposed to be locked due to an improper exit of the application.

Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c |   30 +++++++++++++++++++++++++++
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c |   29 ++++++++++++++++++++++++++
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c  |   33 ++++++++++++++++++++++++++++++
 3 files changed, 92 insertions(+)

diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c
index a9d1b9d..8e2ca1c 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82598.c
@@ -115,6 +115,7 @@ s32 ixgbe_init_ops_82598(struct ixgbe_hw *hw)
 	struct ixgbe_mac_info *mac = &hw->mac;
 	struct ixgbe_phy_info *phy = &hw->phy;
 	s32 ret_val;
+	u16 mask;
 
 	DEBUGFUNC("ixgbe_init_ops_82598");
 
@@ -166,6 +167,35 @@ s32 ixgbe_init_ops_82598(struct ixgbe_hw *hw)
 	/* Manageability interface */
 	mac->ops.set_fw_drv_ver = NULL;
 
+	/* Get bus info */
+	mac->ops.get_bus_info(hw);
+
+	/* Ensure that all locks are released before first NVM or PHY access 
+*/
+
+	/*
+	 * Phy lock should not fail in this early stage. If this is the case,
+	 * it is due to an improper exit of the application.
+	 * So force the release of the faulty lock. Release of common lock
+	 * is done automatically by swfw_sync function.
+	 */
+	mask = IXGBE_GSSR_PHY0_SM << hw->bus.func;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		DEBUGOUT1("SWFW phy%d lock released", hw->bus.func);
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
+
+	/*
+	 * Those one are more tricky since they are common to all ports; but
+	 * swfw_sync retries last long enough (1s) to be almost sure that if
+	 * lock can not be taken it is due to an improper lock of the
+	 * semaphore.
+	 */
+	mask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_MAC_CSR_SM | IXGBE_GSSR_SW_MNG_SM;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		DEBUGOUT("SWFW common locks released");
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
+
 	return ret_val;
 }
 
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
index db07789..ca91967 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
@@ -223,6 +223,7 @@ s32 ixgbe_init_ops_82599(struct ixgbe_hw *hw)
 	struct ixgbe_phy_info *phy = &hw->phy;
 	struct ixgbe_eeprom_info *eeprom = &hw->eeprom;
 	s32 ret_val;
+	u16 mask;
 
 	DEBUGFUNC("ixgbe_init_ops_82599");
 
@@ -291,6 +292,34 @@ s32 ixgbe_init_ops_82599(struct ixgbe_hw *hw)
 	/* Manageability interface */
 	mac->ops.set_fw_drv_ver = &ixgbe_set_fw_drv_ver_generic;
 
+	/* Get bus info */
+	mac->ops.get_bus_info(hw);
+
+	/* Ensure that all locks are released before first NVM or PHY access 
+*/
+
+	/*
+	 * Phy lock should not fail in this early stage. If this is the case,
+	 * it is due to an improper exit of the application.
+	 * So force the release of the faulty lock. Release of common lock
+	 * is done automatically by swfw_sync function.
+	 */
+	mask = IXGBE_GSSR_PHY0_SM << hw->bus.func;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		DEBUGOUT1("SWFW phy%d lock released", hw->bus.func);
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
+
+	/*
+	 * Those one are more tricky since they are common to all ports; but
+	 * swfw_sync retries last long enough (1s) to be almost sure that if
+	 * lock can not be taken it is due to an improper lock of the
+	 * semaphore.
+	 */
+	mask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_MAC_CSR_SM | IXGBE_GSSR_SW_MNG_SM;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		DEBUGOUT("SWFW common locks released");
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
 
 	return ret_val;
 }
diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c
index d3e1730..607c9c7 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_x540.c
@@ -55,6 +55,7 @@ s32 ixgbe_init_ops_X540(struct ixgbe_hw *hw)
 	struct ixgbe_phy_info *phy = &hw->phy;
 	struct ixgbe_eeprom_info *eeprom = &hw->eeprom;
 	s32 ret_val;
+	u16 mask;
 
 	DEBUGFUNC("ixgbe_init_ops_X540");
 
@@ -141,6 +142,38 @@ s32 ixgbe_init_ops_X540(struct ixgbe_hw *hw)
 	/* Manageability interface */
 	mac->ops.set_fw_drv_ver = &ixgbe_set_fw_drv_ver_generic;
 
+	/* Get bus info */
+	mac->ops.get_bus_info(hw);
+
+	/* Ensure that all locks are released before first NVM or PHY access 
+*/
+
+	/*
+	 * Phy lock should not fail in this early stage. If this is the case,
+	 * it is due to an improper exit of the application.
+	 * So force the release of the faulty lock.
+	 */
+	mask = IXGBE_GSSR_PHY0_SM << hw->bus.func;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		if (ixgbe_get_swfw_sync_semaphore(hw) < 0) {
+			DEBUGOUT("SMBI lock released");
+		}
+		ixgbe_release_swfw_sync_semaphore(hw);
+		DEBUGOUT1("SWFW phy%d lock released", hw->bus.func);
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
+
+	/*
+	 * Those one are more tricky since they are common to all ports; but
+	 * swfw_sync retries last long enough (1s) to be almost sure that if
+	 * lock can not be taken it is due to an improper lock of the
+	 * semaphore.
+	 */
+	mask = IXGBE_GSSR_EEP_SM | IXGBE_GSSR_MAC_CSR_SM | IXGBE_GSSR_SW_MNG_SM;
+	if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
+		DEBUGOUT("SWFW common locks released");
+	}
+	hw->mac.ops.release_swfw_sync(hw, mask);
+
 	return ret_val;
 }
 
--
1.7.10.4

--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.