From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9781D6931 for ; Wed, 19 Feb 2014 18:50:30 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 19 Feb 2014 09:51:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,507,1389772800"; d="scan'208";a="458240615" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 19 Feb 2014 09:51:49 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.202]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0123.003; Wed, 19 Feb 2014 17:51:41 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization Thread-Index: AQHPLZMC4KvhkhTmzE2IeD2/d2ZNepq81HUw Date: Wed, 19 Feb 2014 17:51:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725808E68AFB@IRSMSX105.ger.corp.intel.com> References: <1392811162-28527-1-git-send-email-didier.pallard@6wind.com> <1392811162-28527-2-git-send-email-didier.pallard@6wind.com> <2601191342CEEE43887BDE71AB97725808E689E6@IRSMSX105.ger.corp.intel.com> <201402191752.11989.thomas.monjalon@6wind.com> In-Reply-To: <201402191752.11989.thomas.monjalon@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 17:50:33 -0000 Hi Thomas, I am afraid I couldn't send you an url we are using. We take it from internal Intel ND repository. Though I think, that latest available to download from Intel ixgbe driver f= or FreeBSD should have pretty close codebase. = As a rule of thumb in our internal policy: we take shared code from ND and = treat it as read-only (the only exception: ixgbe/ixgbe_osdep.h). Otherwise it might become quite messy pretty quickly. To overcome some problems or shortcomings in ND code people usually use wra= ppers at the upper layer - that way was implemented bypass support, loopba= ck support, plus some other fixes (reported number of queues per VF, etc). I wonder couldn't your fix also be pushed to the upper layer (in ixgbe_ethd= ev.c or something)? Thanks Konstantin = -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] = Sent: Wednesday, February 19, 2014 4:52 PM To: Ananyev, Konstantin Cc: Didier Pallard; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked sema= phores on initialization 19/02/2014 13:41, Ananyev, Konstantin: > Can the patch be reworked to keep changes under librte_pmd_ixgbe/ixgbe = > directory untouched? Those files are derived directly from the BSD = > driver baseline, and any changes will make future merges of newer code = > more challenging. The changes should be limited to files in the = > librte_pmd_ixgbe directory (and ethdev). Thanks Please, could you send an url to the BSD driver baseline ? By the way, git is very good at rebasing such patches. And if the fix is good, it should be applied on the baseline. Refusing a fix without alternative is not an option. -- Thomas -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.