From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails
Date: Thu, 22 May 2014 15:51:04 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580EFA81D9@IRSMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <3243438.tFUQaShmoV@xps13>
Hi Thomas,
I planned to, but very unlikely that it would happen that week.
Thanks
Konstantin
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Thursday, May 22, 2014 4:47 PM
To: Ananyev, Konstantin
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails
2014-04-17 17:00, Thomas Monjalon:
> Hi Konstantin,
>
> 2014-04-07 08:53, Ananyev, Konstantin:
> > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf
> > corruption.
> > I think it should be something like that instead:
> >
> > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c
> > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
> > @@ -205,8 +205,9 @@ eth_pcap_tx(void *queue,
> >
> > mbuf = bufs[i];
> > ret = pcap_sendpacket(tx_queue->pcap, (u_char*)
> >
> > mbuf->pkt.data, mbuf->pkt.data_len);
> > - if(likely(!ret))
> > - num_tx++;
> > + if(unlikely(ret != 0))
> > + break;
> > + num_tx++;
> >
> > rte_pktmbuf_free(mbuf);
> >
> > }
>
> Please could you send a patch with a commit log as described in
> http://dpdk.org/dev#send ?
I think you haven't sent patch for this bug.
Do you plan to do so?
Thanks
--
Thomas
prev parent reply other threads:[~2014-05-22 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 11:08 Meir Tseitlin
2014-04-01 11:53 ` Meir Tseitlin
2014-04-07 7:26 ` Olivier MATZ
2014-04-07 8:53 ` Ananyev, Konstantin
2014-04-17 15:00 ` Thomas Monjalon
2014-05-22 15:47 ` Thomas Monjalon
2014-05-22 15:51 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580EFA81D9@IRSMSX105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).